Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review654 --- indra/llvfs/llvfs.cpp

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Brad Kittenbrink
On April 27, 2011, 3:30 a.m., Boroondas Gupte wrote: indra/llvfs/llvfs.cpp, lines 1716-1717 http://codereview.secondlife.com/r/278/diff/1/?file=1511#file1511line1716 When index_size == 0, wouldn't it be more appropriate to skip the steps that require taking the address of element

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Boroondas Gupte
On April 27, 2011, 3:30 a.m., Boroondas Gupte wrote: indra/llvfs/llvfs.cpp, lines 1716-1717 http://codereview.secondlife.com/r/278/diff/1/?file=1511#file1511line1716 When index_size == 0, wouldn't it be more appropriate to skip the steps that require taking the address of element

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-27 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review661 --- Ship it! Ready to rock! - Boroondas On April 26, 2011, 5:31

[opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-26 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/ --- Review request for Viewer. Summary --- Fix for a minor buffer overrun

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-26 Thread Stone Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review652 --- Ship it! hg rm llconfusingcode.cpp is better, but llmax() works