Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

2011-03-28 Thread Philippe (Merov) Bossut
Hi Robin, Fantastic! I just went through the code and I'm not done reviewing and putting my "Ship it!" stamp on it but I wanted to thank you for completing this massive task. Thanks a lot! Cheers, - Merov On Mon, Mar 28, 2011 at 4:46 AM, Robin Cornelius wrote: >This is an automatically gene

Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

2011-03-29 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/232/#review519 --- Excellent! Except for a handful of minor typos, I've no problem wi

Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

2011-03-29 Thread Monty Brandenberg
> On March 29, 2011, 4:19 p.m., Merov Linden wrote: > > Excellent! Except for a handful of minor typos, I've no problem with that > > code. One thing important though before we merge is to use the correct lgpl > > header for the new files. > > > > I hope others will also review and try it out

Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

2011-04-01 Thread Monty Brandenberg
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/232/#review537 --- Final pass through the code for review (I'll do this again after c