Re: Patch: save/load state of SHA1

2007-06-12 Thread Nanno Langstraat
Richard Salz wrote: Being able to load/save the digest state is a good idea. Management of the buffer should be left to the caller, however. Much simpler and cleaner that way. For example, work like the DER/i2d routines: if given a NULL pointer, return how much space is needed. Or provide

Re: Patch: save/load state of SHA1

2007-06-12 Thread Nanno Langstraat
Darryl Miles wrote: SHA1_Drop() seems like a bad name to me, maybe a better name would be SHA1_Clear() or SHA1_Reset() if the intention is to cause the internal state of the SHA1 to reset back to SHA1_Init() but it MUST be used on an already initialized SHA1 object. Ah, I should have made

Re: EBCDIC patch

2007-06-12 Thread Yo BZH
It didn't seem to get through the first time. On 6/11/07, Yoann Le Corvic [EMAIL PROTECTED] wrote: Hi all, I am currently working on getting Openssl up and running on mainframe (USS partition). It seems we are nopt the only ones as someone has already released a patch for previous versions :

Re: Patch: save/load state of SHA1

2007-06-12 Thread Darryl Miles
Nanno Langstraat wrote: The intended use of the patch is to call SHA1_Load_State() directly, not SHA1_Init() followed by SHA1_Load_State(). In other words: * The application starts by freely choosing either SHA1_Init() or SHA1_Load_State() * The application ends by freely choosing

[openssl.org #1537] [PATCH] Fix header path for pq_compat.h

2007-06-12 Thread Jason Schoon via RT
pq_compat.h calls out to opensslconf.h as a local include file (i.e. with quotes). The convention used everywhere else in the code is to call into the openssl directory as a system include (i.e. openssl/). --- pq_compat.h.orig2007-06-12 09:08:43.0 -0500 +++ pq_compat.h2007-06-12

Re: Patch: save/load state of SHA1

2007-06-12 Thread Nanno Langstraat
Darryl Miles wrote: Nanno Langstraat wrote: The intended use of the patch is to call SHA1_Load_State() directly, not SHA1_Init() followed by SHA1_Load_State(). In other words: * The application starts by freely choosing either SHA1_Init() or SHA1_Load_State() * The application

Re: Patch: save/load state of SHA1

2007-06-12 Thread Nanno Langstraat
Darryl Miles wrote: Nanno Langstraat wrote: I'm not sure if your method of versioning the state information is sufficient, I would like to propose that this problem domain be left mainly upto the application to deal with. Leaving this up to the application is another way of saying that

Re: Patch: save/load state of SHA1 - v2

2007-06-12 Thread Nanno Langstraat
v2 of the SHA save patch. Now against the top level of the source tree. * Now lets user alloc the buffer. * '_Default_Version()' call added. * Man page documentation added. Nanno diff -Nru ../openssl-0.9.8e/crypto/sha/sha.h crypto/sha/sha.h --- ../openssl-0.9.8e/crypto/sha/sha.h

Re: Patch: save/load state of SHA1

2007-06-12 Thread Darryl Miles
Nanno Langstraat wrote: I think you may have misread my quoted text. It specifically says that the application can choose the beginning operation freely and choose the ending operation freely. I.e. that the application can mix freely. Point understood. The man page just needs to be clear

Re: Patch: save/load state of SHA1 - v2

2007-06-12 Thread Goetz Babin-Ebell
--On Jun 12, 2007 18:28:49 +0200 Nanno Langstraat [EMAIL PROTECTED] wrote: v2 of the SHA save patch. Is there a special reason to limit it to SHA ? Why not a EVP_MD_CTX_{load|save} ? Goetz -- DMCA: The greed of the few outweights the freedom of the many pgpFVb5vOyptj.pgp Description: PGP

Re: Patch: save/load state of SHA1 - v2

2007-06-12 Thread Dr. Stephen Henson
On Tue, Jun 12, 2007, Goetz Babin-Ebell wrote: --On Jun 12, 2007 18:28:49 +0200 Nanno Langstraat [EMAIL PROTECTED] wrote: v2 of the SHA save patch. Is there a special reason to limit it to SHA ? Why not a EVP_MD_CTX_{load|save} ? That would be the preferred option since we've

Re: Patch: save/load state of SHA1 - v2

2007-06-12 Thread Nanno Langstraat
Dr. Stephen Henson wrote: On Tue, Jun 12, 2007, Goetz Babin-Ebell wrote: --On Jun 12, 2007 18:28:49 +0200 Nanno Langstraat [EMAIL PROTECTED] wrote: v2 of the SHA save patch. Is there a special reason to limit it to SHA ? Why not a EVP_MD_CTX_{load|save} ? That would be

Re: Signing XML document with 2 references

2007-06-12 Thread Roumen Petrov
No it is exc-c14n ( http://www.w3.org/TR/xml-exc-c14n/ ) not c14n http://www.w3.org/TR/xml-exc-c14n/ AndrewHartley wrote: Yes I did c14n the entire XML. I'll give the XSLSec library a go, thanks. Richard Salz wrote: It would help a great deal if you posted a sample signature. Did you