[PATCH] openssl/crypto/armcap.c: fix a typo in OPENSSL_rdtsc

2013-09-12 Thread Kyle McMartin
a | 1 is always true, regardless of OPENSSL_armcap_P, and mrc cp15 will fail on = v6. --- a/crypto/armcap.c +++ b/crypto/armcap.c @@ -23,7 +23,7 @@ unsigned int _armv7_tick(void); unsigned int OPENSSL_rdtsc(void) { - if (OPENSSL_armcap_P|ARMV7_TICK) + if (OPENSSL_armcap_P

[PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-12 Thread Kyle McMartin
More reliable than playing games with signal handling in libraries. --- a/crypto/armcap.c +++ b/crypto/armcap.c @@ -9,11 +9,6 @@ unsigned int OPENSSL_armcap_P; -static sigset_t all_masked; - -static sigjmp_buf ill_jmp; -static void ill_handler (int sig) { siglongjmp(ill_jmp,sig); } - /* *

Re: [openssl.org #2459] ecdsa_method declaration prevents use in implementing a dynamic engine

2013-09-12 Thread Dr. Stephen Henson
On Thu, Sep 12, 2013, Douglas E. Engert wrote: On 9/11/2013 2:01 PM, Stephen Henson via RT wrote: On Wed Sep 11 17:52:03 2013, deeng...@anl.gov wrote: Attached is a patch to move the definition of ecdsa_method from src/crypto/ecdsa/ecs_locl.h to ecdsa.h and move the definition if

[openssl.org #3126] [PATCH 1.0.1e] armcap.c: use getauxv on glibc to find caps

2013-09-12 Thread Kyle McMartin via RT
More reliable than playing games with signal handling in libraries. --- a/crypto/armcap.c +++ b/crypto/armcap.c @@ -9,11 +9,6 @@ unsigned int OPENSSL_armcap_P; -static sigset_t all_masked; - -static sigjmp_buf ill_jmp; -static void ill_handler (int sig) { siglongjmp(ill_jmp,sig); } - /* *

Dual_EC_DRBG

2013-09-12 Thread Hanno Böck
Hi, Probably everyone knows by now that Dual_EC_DRBG got some bad reputation lately: http://www.wired.com/politics/security/commentary/securitymatters/2007/11/securitymatters_1115 Matthew Green points out that OpenSSL is one of the few libs that actually implements Dual_EC_DRBG:

Re: [openssl.org #2459] ecdsa_method declaration prevents use in implementing a dynamic engine

2013-09-12 Thread Douglas E. Engert
On 9/11/2013 2:01 PM, Stephen Henson via RT wrote: On Wed Sep 11 17:52:03 2013, deeng...@anl.gov wrote: Attached is a patch to move the definition of ecdsa_method from src/crypto/ecdsa/ecs_locl.h to ecdsa.h and move the definition if ecdh_method from src/crypto/ecdh/ech_locl.h to ecdh.h

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-12 Thread Mike Frysinger
On Wednesday 11 September 2013 10:49:36 Kyle McMartin wrote: +#if defined(__GNUC__) __GNUC__=2 +void OPENSSL_cpuid_setup(void) __attribute__((constructor)); +#endif +void OPENSSL_cpuid_setup(void) this can be made simpler: #if defined(__GNUC__) __GNUC__=2

[openssl.org #3124] potential bug in ssl/s3_cbc.c

2013-09-12 Thread Arthur Mesh via RT
I am not 100% sure this is a real bug, hence first tried mailing openssl-users instead of rt@. But since there was no reply, I am sending this to rt@ 641 if (is_sslv3) 642 { snip 647 unsigned overhang = header_length-md_block_size;

[openssl.org #3125] [PATCH 1.0.1e] openssl/crypto/armcap.c: fix a typo in OPENSSL_rdtsc

2013-09-12 Thread Kyle McMartin via RT
a | 1 is always true, regardless of OPENSSL_armcap_P, and mrc cp15 will fail on = v6. --- a/crypto/armcap.c +++ b/crypto/armcap.c @@ -23,7 +23,7 @@ unsigned int _armv7_tick(void); unsigned int OPENSSL_rdtsc(void) { - if (OPENSSL_armcap_P|ARMV7_TICK) + if (OPENSSL_armcap_P

Re: [openssl.org #2459] ecdsa_method declaration prevents use in implementing a dynamic engine

2013-09-12 Thread Douglas E. Engert via RT
On 9/11/2013 2:01 PM, Stephen Henson via RT wrote: On Wed Sep 11 17:52:03 2013, deeng...@anl.gov wrote: Attached is a patch to move the definition of ecdsa_method from src/crypto/ecdsa/ecs_locl.h to ecdsa.h and move the definition if ecdh_method from src/crypto/ecdh/ech_locl.h to ecdh.h

Re: Dual_EC_DRBG

2013-09-12 Thread Dr. Stephen Henson
On Thu, Sep 12, 2013, Hanno Bck wrote: Hi, Probably everyone knows by now that Dual_EC_DRBG got some bad reputation lately: http://www.wired.com/politics/security/commentary/securitymatters/2007/11/securitymatters_1115 Matthew Green points out that OpenSSL is one of the few libs that