Re: [openssl-dev] [openssl.org #4458] "implicitly declared function" warnings due to missing include

2016-05-25 Thread Viktor Dukhovni
On Wed, May 25, 2016 at 09:46:02PM +, Richard Levitte via RT wrote: > I don't get such warnings. Can you tell me what system and with what tool > chain > (including versions)? I think that the report is correct, we must be getting away with on most platforms. On NetBSD, for example,

[openssl-dev] Syncing OpenSSL and BoringSSL mont ASM code

2016-05-25 Thread Brian Smith
1. Please see https://boringssl.googlesource.com/boringssl/+/75b833cc819a9d189adb0fdd56327bee600ff9e9 . I think it would be good for OpenSSL to work with Google to integrate this patch. 2. Is the `__chkstk` code that was added [1] to `bn_mul_mont` really necessary? I noticed that when BoringSSL

[openssl-dev] Why is `volatile` used in MOD_EXP_CTIME_COPY_FROM_PREBUF?

2016-05-25 Thread Brian Smith
See https://github.com/openssl/openssl/commit/d6482a82bc2228327aa4ba98aeeecd9979542a31#diff-3aca3afd18ad75a8f6a09a9860bc6ef5R631 + volatile BN_ULONG *table = (volatile BN_ULONG *)buf; Why is `volatile` used here? Is it to work around the effective type (strict aliasing) violations or for some

[openssl-dev] [openssl.org #4501] bug in BN_mod_word

2016-05-25 Thread Matt Caswell via RT
On Thu Apr 07 11:44:09 2016, peter.chernys...@gmail.com wrote: > Добрый день! > программа библиотеки BN_mod_word > BN_ULONG BN_mod_word(const BIGNUM *a, BN_ULONG w); > > работает неверно на 64 бит машине при некоторых w>2^32, хотя объявлена как > BN_ULONG (64 бита). > > Петр > > Hello! > BN part

[openssl-dev] [openssl.org #4488] PATCH: fix Windows "The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name..."

2016-05-25 Thread Richard Levitte via RT
This has made it to master. Closing this ticket. Cheers, Richard On Wed May 25 21:42:40 2016, levitte wrote: > Patch applied, https://github.com/openssl/openssl/pull/1129 > > Furthermore, I merged ticket 4488 and 4489, because the solution is > all in the > same commit. > > -- > Richard Levitte

Re: [openssl-dev] Making assembly language optimizations working on Cortex-M3

2016-05-25 Thread Brian Smith
Andy Polyakov wrote: > > Cortex-M platforms are so limited that every bit of performance and > > space savings matters. So, I think it is definitely worthwhile to > > support the non-NEON ARMv7-M configuration. One easy way to do this > > would be to avoid building NEON code

Re: [openssl-dev] Making assembly language optimizations working on Cortex-M3

2016-05-25 Thread Andy Polyakov
> > > http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=11208dcfb9105e8afa37233185decefd45e89e17 > made whole assembly pack Thumb2-friendly, so that now you should be able > to compile all modules. Please, double-check. > > > This is awesome! > > I have a question about

Re: [openssl-dev] Making assembly language optimizations working on Cortex-M3

2016-05-25 Thread Brian Smith
[Sorry for the **long** delay in responding.] Andy Polyakov wrote: > > http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=11208dcfb9105e8afa37233185decefd45e89e17 > made whole assembly pack Thumb2-friendly, so that now you should be able > to compile all modules.

[openssl-dev] [openssl.org #4458] "implicitly declared function" warnings due to missing include

2016-05-25 Thread Richard Levitte via RT
I don't get such warnings. Can you tell me what system and with what tool chain (including versions)? On Sun Mar 20 13:07:43 2016, noloa...@gmail.com wrote: > The missing include caused a number of "implicitly > declared function" warnings due to use of strcmpcase and strncmpcase. > > $ egrep

[openssl-dev] [openssl.org #4488] PATCH: fix Windows "The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name..."

2016-05-25 Thread Richard Levitte via RT
Patch applied, https://github.com/openssl/openssl/pull/1129 Furthermore, I merged ticket 4488 and 4489, because the solution is all in the same commit. -- Richard Levitte levi...@openssl.org -- Ticket here: http://rt.openssl.org/Ticket/Display.html?id=4488 Please log in as guest with password

[openssl-dev] [openssl.org #4489] PATCH: fix Windows deprecated strdup in crypto\conf\conf_lib.c

2016-05-25 Thread Richard Levitte via RT
On Tue Mar 29 12:02:41 2016, noloa...@gmail.com wrote: > >>> $ cat conf_lib.patch > >>> diff --git a/crypto/conf/conf_lib.c b/crypto/conf/conf_lib.c > >>> index f197714..7bc3ac0 100644 > >>> --- a/crypto/conf/conf_lib.c > >>> +++ b/crypto/conf/conf_lib.c > >>> @@ -392,7 +392,7 @@ void > >>>

Re: [openssl-dev] [openssl.org #4491] [PATCH] VMX-crypto: Add XTS support

2016-05-25 Thread Andy Polyakov via RT
> Author: Leonidas Da Silva Barbosa > ASM implementation > > Signed-off-by: Paulo Flabiano Smorigo > Signed-off-by: Leonidas Da Silva Barbosa > --- > +my

Re: [openssl-dev] Current Github build fails

2016-05-25 Thread Richard Levitte
... and has now made it to master. Cheers, richard In message <20160525.205653.1298317536965356146.levi...@openssl.org> on Wed, 25 May 2016 20:56:53 +0200 (CEST), Richard Levitte said: levitte> This should solve the problem: levitte> levitte>

Re: [openssl-dev] Current Github build fails

2016-05-25 Thread Richard Levitte
This should solve the problem: https://github.com/openssl/openssl/pull/1128 Cheers, Richard In message <2084b495-b2bb-4771-b9a8-d811c597c...@openssl.org> on Wed, 25 May 2016 16:58:34 +0200, Richard Levitte said: levitte> Yes. There's a bug where the 'clean' target

Re: [openssl-dev] Current Github build fails

2016-05-25 Thread Richard Levitte
Yes. There's a bug where the 'clean' target removes header files generated by Configure. I'll fix later tonight. Cheers Richard "Blumenthal, Uri - 0553 - MITLL" skrev: (25 maj 2016 16:50:00 CEST) >$ ./Configure darwin64-x86_64-cc threads shared zlib

[openssl-dev] Current Github build fails

2016-05-25 Thread Blumenthal, Uri - 0553 - MITLL
$ ./Configure darwin64-x86_64-cc threads shared zlib enable-ec_nistp_64_gcc_128 enable-rfc3779 --prefix=/Users/ur20980/src/openssl-1.1 --openssldir=/Users/ur20980/src/openssl-1.1/etc Configuring OpenSSL version 1.1.0-pre6-dev (0x0x1016L) no-asan [default] OPENSSL_NO_ASAN (skip

[openssl-dev] [openssl.org #4486] PATCH: fix NMAKE fatal error U1073: "don't know how to make 'LNAME\openssl\Configurations\windows-makefile.tmpl'"

2016-05-25 Thread Richard Levitte via RT
Now that 4492 was closed, I could give this a go... and no, the proposed patch wasn't enough, there were a few more places that needed extra quotes. https://github.com/openssl/openssl/pull/1125 Cheers, Richard On Tue May 24 15:46:07 2016, levitte wrote: > I'm surprised so little is needed...

[openssl-dev] [openssl.org #4492] Configure, Unix and Linux, and malformed command line when path includes spaces

2016-05-25 Thread Richard Levitte via RT
That has now made it to master. Closing ticket, submit a new ticket if you find further issues. Cheers, Richard On Tue May 24 15:45:08 2016, levitte wrote: > I just pushed a pull request that I think solves this. > > https://github.com/openssl/openssl/pull/1120 > > Care to try it? > > Cheers, >