Re: Typo ?

2006-02-01 Thread Gabriel Forté
On Wed, Feb 01, 2006 at 06:05:51PM +0100, Gabriel Forté wrote: > > but looking at the code again I think it really should be > > "if (data->state != BIO_CONN_S_OK)" as conn_state() does nothing > > if the BIO is already in the BIO_CONN_S_OK state. huh-oh! I just r

Re: Typo ?

2006-02-01 Thread Gabriel Forté
that, but when I do a connect(2) call on unix sockets, I like to have my socket right now, not just after the first read() or write() :P IMHO, the negation in your commit should be removed, and the if statement (which looks like it's been some "miraculously-working" typo since a few y

Re: BIO_do_connect does not connect (bug?)

2005-11-10 Thread Gabriel Forté
t;) and the nature of the bug makes me worry that no or little testing was done before commiting. it would be nice to provide some feedback about that since it causes a serious functional regression when using BIO_s_connect (at least in my case). cheers, -- Gabriel Forté <[EMAIL