[openssl-dev] [openssl.org #3848] [PATCH] Fix memory leak caused by not calling SSL_COMP_free_compression_methods()

2015-05-13 Thread Gunnar Kudrjavets via RT
Hello, Currently 'apps_shutdown()' in 'openssl.c' isn't freeing the compression methods. This is causing the CRT debug heap (and I assume various other tools) to indicate a memory leak. Though OS will free all the resources when user-mode application exits, it's better to do this explicitly inside

[openssl-dev] [openssl.org #3847] [PATCH] Fix the heap corruption in libeay32!OBJ_add_object

2015-05-13 Thread Gunnar Kudrjavets via RT
Hello, Original 'sizeof(ADDED_OBJ)' was replaced with 'sizeof(*ao)'. However, they return different sizes. Therefore as the result heap gets corrupted and at some point later debug version of malloc() detects the corruption. Issue reproduces with either enabling CRT debug heap or Application Veri

[openssl-dev] [openssl.org #3835] [PATCH] Initialize potentially uninitialized local variables

2015-05-05 Thread Gunnar Kudrjavets via RT
Hello, Fix all the instances of MSVC warning C4701 (potentially uninitialized local variable 'name' used). This warning pretty much means that there's a code path which results in uninitialized variables being used or returned. Thank you, Gunnar Kudrjavets >From 3f65a16efe0b78f7c994b0317c7ef0ee

[openssl-dev] [openssl.org #3830] [PATCH] Fix test execution on Windows

2015-05-01 Thread Gunnar Kudrjavets via RT
Hello, Summary: fix test case execution on Windows so that all the tests will be run. Additional data: 1) Operating systems affected: all versions of Windows. 2) OpenSSL versions affected: all versions running on Windows. Thank you, Gunnar Kudrjavets >From 3a27a5e98f883034c0d61928f6e71f364fc

[openssl-dev] [openssl.org #3823] [PATCH] Improve the robustness of event logging

2015-04-28 Thread Gunnar Kudrjavets via RT
Hello, Summary: handle possible failures when writing a message to the event log. In debug builds, send data to the debugger as a last resort. Additional data: 1) Operating systems affected: all versions of Windows. 2) OpenSSL versions affected: all versions running on Windows. Thank you, Gun

[openssl-dev] [openssl.org #3820] [PATCH] Remove an unnecessary call to USER32!GetDesktopWindow

2015-04-25 Thread Gunnar Kudrjavets via RT
Hello, Summary: currently function LIBEAY32!OPENSSL_isservice() calls USER32!GetDesktopWindow() to determine if the code is running as a service or not. That function call is not necessary. Attached patch has the details. Additional data: 1) Operating systems affected: all version of Windows.