Re: [openssl-dev] [PATCH] Fix broken argument parsing for genrsa

2015-07-29 Thread Salz, Rich
See the Feedback and Contributions section on the main wiki page: https://wiki.openssl.org/index.php/Main_Page Also this page: https://wiki.openssl.org/index.php/Use_of_Git Also some stuff here: https://wiki.openssl.org/index.php/Developing_For_OpenSSL On the website here:

Re: [openssl-dev] [PATCH] Fix broken argument parsing for genrsa

2015-07-28 Thread Matt Caswell
On 28/07/15 16:22, Adam Eijdenberg wrote: Sorry Rich, I didn't mean to imply it was (especially since it included the weekend!) - I'm still trying to understand the correct workflow for this project - do you normally prefer mail to this list or pull requests with that type of patch? The

Re: [openssl-dev] [PATCH] Fix broken argument parsing for genrsa

2015-07-28 Thread Adam Eijdenberg
Sorry Rich, I didn't mean to imply it was (especially since it included the weekend!) - I'm still trying to understand the correct workflow for this project - do you normally prefer mail to this list or pull requests with that type of patch? The README file talks about sending patches to this

Re: [openssl-dev] [PATCH] Fix broken argument parsing for genrsa

2015-07-28 Thread Salz, Rich
We saw your pull request. Three days is not a long time. ___ openssl-dev mailing list To unsubscribe: https://mta.openssl.org/mailman/listinfo/openssl-dev

[openssl-dev] [PATCH] Fix broken argument parsing for genrsa

2015-07-28 Thread Adam Eijdenberg
HI openssl-dev, This is my first patch, so hope I'm following the right process. The argument parsing for openssl genrsa is missing a break; statement and as a consequence control the users gets a set of spurious warnings about a missing engine that they didn't actually intentionally specify. A

Re: [openssl-dev] [PATCH] Fix broken argument parsing for genrsa

2015-07-28 Thread Matt Caswell
On 28/07/15 16:54, Salz, Rich wrote: or pull requests with that type of patch? The README file talks about sending patches to this list, whereas the Wiki talks about GitHub pull requests so I wanted to make sure I was following the right process. We really need to sort that out! :-) Can