[openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-27 Thread Richard Levitte via RT
And merged, commit ce84456ddf4e57c18a84858755b8b90c183a270e. Closing this ticket. Vid Sat, 26 Mar 2016 kl. 06.35.55, skrev levitte: > Frankly, you did all the work. With your analysis, it became very easy to > figure out what needed to be done. Low hanging fruit ;-) > > So, thank you! > >

Re: [openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-27 Thread noloa...@gmail.com via RT
On Fri, Mar 25, 2016 at 7:05 PM, Richard Levitte via RT wrote: > I've attached a tentative patch for test/recipes/bc.pl. Would you be willing > to > try it out? OpenSSL master (c828cd7) experienced what appeared to be the same issue under Windows 7 Pro x64 with Strawberry

Re: [openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-27 Thread Jeffrey Walton
On Fri, Mar 25, 2016 at 7:05 PM, Richard Levitte via RT wrote: > I've attached a tentative patch for test/recipes/bc.pl. Would you be willing > to > try it out? OpenSSL master (c828cd7) experienced what appeared to be the same issue under Windows 7 Pro x64 with Strawberry

[openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-26 Thread Richard Levitte via RT
Frankly, you did all the work. With your analysis, it became very easy to figure out what needed to be done. Low hanging fruit ;-) So, thank you! Cheers, Richard Vid Sat, 26 Mar 2016 kl. 02.38.47, skrev craigbe...@mac.com: > Wow, that was fast. The patch looks good here: now all tests pass on >

Re: [openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-25 Thread Craig A. Berry via RT
Wow, that was fast. The patch looks good here: now all tests pass on systems with and without the Math::BigInt changes. Thanks! > On Mar 25, 2016, at 6:05 PM, Richard Levitte via RT wrote: > > I've attached a tentative patch for test/recipes/bc.pl. Would you be willing >

[openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-25 Thread Richard Levitte via RT
I've attached a tentative patch for test/recipes/bc.pl. Would you be willing to try it out? Vid Fre, 25 Mar 2016 kl. 21.29.50, skrev levitte: > Vid Fre, 25 Mar 2016 kl. 20.51.10, skrev craigbe...@mac.com: > > I reported this to the Math::BigInt maintainer, who explains that the > > change fixes a

[openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-25 Thread Richard Levitte via RT
Vid Fre, 25 Mar 2016 kl. 20.51.10, skrev craigbe...@mac.com: > I reported this to the Math::BigInt maintainer, who explains that the > change fixes a bug in which, "The code did truncated division whereas > the documentation said that floored division was used" and he changed > the code to match

[openssl-dev] [openssl.org #4485] big number tests and Math::BigInt changes

2016-03-25 Thread Craig A. Berry via RT
I’ve seen test failures in a recent build from git master that look like: Failed! -9494949494FAFFE00064646464 / 4 - -25252525253EBFF800 => -0x1 Failed! -9494949494FAFFE00064646464 / 8 -