Re: [openssl-dev] Duplicate APIs?

2016-02-08 Thread Viktor Dukhovni
On Mon, Feb 08, 2016 at 10:17:37AM -0500, Viktor Dukhovni wrote: > What'll likely happen is that SSL_session_reused() will be the > new name of the SSL_cache_hit() function, and SSL_cache_hit will > become a macro referencing that function: > >int SSL_session_reused(const SSL *ssl); >#if

Re: [openssl-dev] Duplicate APIs?

2016-02-08 Thread Viktor Dukhovni
> On Feb 8, 2016, at 10:06 AM, Short, Todd wrote: > > I noticed that: > > * SSL_cache_hit(SSL*), and > * SSL_session_reused(SSL*ssl) --> > SSL_ctrl(ssl,SSL_CTRL_GET_SESSION_REUSED,0,NULL) > > are practically the same thing; both return s->hit. > > Are both really needed? I started a thread

[openssl-dev] Duplicate APIs?

2016-02-08 Thread Short, Todd
Hi, I know OpenSSL is making 1.1 not ABI compliant to 1.0, so, maybe now is a good time to clean this up? I noticed that: * SSL_cache_hit(SSL*), and * SSL_session_reused(SSL*ssl) --> SSL_ctrl(ssl,SSL_CTRL_GET_SESSION_REUSED,0,NULL) are practically the same thing; both return s->hit. Are both