Re: [openssl-dev] Removing gcm128_context->H for non-1-bit builds

2016-06-11 Thread Brian Smith
Andy Polyakov wrote: > In other words we *are* talking about super-custom code with very > special needs. As already mentioned, it would be next to impossible to > justify customization of OpenSSL to accommodate overly specific > requirements. And given above description it

Re: [openssl-dev] Removing gcm128_context->H for non-1-bit builds

2016-06-11 Thread Andy Polyakov
>>> Could somebody adjust who understand the assembly code (probably Andy) >>> modify it to use symbolic names for the offsets that are used to >>> access Xi, H, Htable? If so, then I can write the patch to >>> conditionally exclude `H` on platforms that don't need it after >>>

Re: [openssl-dev] Removing gcm128_context->H for non-1-bit builds

2016-06-08 Thread Brian Smith
On Wed, Jun 8, 2016 at 12:40 AM, Andy Polyakov wrote: >> I noticed that the `H` member of `gcm128_context` seems to be >> unnecessary for builds that aren't using the 1-bit GCM math. > > Not true. It is actually used in s390x assembly module. And I mean both > H and Htable. I

Re: [openssl-dev] Removing gcm128_context->H for non-1-bit builds

2016-06-08 Thread Andy Polyakov
> One can *probably* discuss > that it would be appropriate to *facilitate* omission of H in context > *other than* OpenSSL by avoiding H during most of the setup procedure. > See attached patch for example. But do note that I'm not saying that it > works or suggesting to include it right away, I

Re: [openssl-dev] Removing gcm128_context->H for non-1-bit builds

2016-06-08 Thread Andy Polyakov
> I noticed that the `H` member of `gcm128_context` seems to be > unnecessary for builds that aren't using the 1-bit GCM math. Since > this member is large (128-bits) and some applications may have lots of > GCM contexts relative to the amount of memory they have, I think it > would be great to

[openssl-dev] Removing gcm128_context->H for non-1-bit builds

2016-06-07 Thread Brian Smith
I noticed that the `H` member of `gcm128_context` seems to be unnecessary for builds that aren't using the 1-bit GCM math. Since this member is large (128-bits) and some applications may have lots of GCM contexts relative to the amount of memory they have, I think it would be great to only put the