Re: [openssl.org #2230] [PATCH] DTLS reassembly

2010-04-26 Thread Robin Seggelmann via RT
On Apr 26, 2010, at 12:44 PM, Stephen Henson via RT wrote: >> [seggelm...@fh-muenster.de - Mon Apr 26 11:04:29 2010]: >> >> >> You're right. The loop was written in the assumption that the control >> variable in the for loop can become -1. Since the variable type was >> changed to unsigned

[openssl.org #2230] [PATCH] DTLS reassembly

2010-04-26 Thread Stephen Henson via RT
> [seggelm...@fh-muenster.de - Mon Apr 26 11:04:29 2010]: > > > You're right. The loop was written in the assumption that the control >variable in the for loop can become -1. Since the variable type was >changed to unsigned long, that didn't work anymore and my fix also >didn't correc

Re: [openssl.org #2230] [PATCH] DTLS reassembly

2010-04-14 Thread Robin Seggelmann via RT
On Apr 14, 2010, at 2:20 PM, Stephen Henson via RT wrote: > This patch appears to be broken on OpenSSL 0.9.8 it gives warnings: > > d1_both.c: In function ‘dtls1_reassemble_fragment’: > d1_both.c:623: error: passing argument 2 of ‘pqueue_find’ makes integer > from pointer without a cast > ../incl

[openssl.org #2230] [PATCH] DTLS reassembly

2010-04-14 Thread Stephen Henson via RT
This patch appears to be broken on OpenSSL 0.9.8 it gives warnings: d1_both.c: In function ‘dtls1_reassemble_fragment’: d1_both.c:623: error: passing argument 2 of ‘pqueue_find’ makes integer from pointer without a cast ../include/openssl/pqueue.h:89: note: expected ‘long unsigned int’ but argumen

[openssl.org #2230] [PATCH] DTLS reassembly

2010-04-08 Thread Robin Seggelmann via RT
The reassembly for fragmented DTLS handshake messages only works if the fragments don't overlap, aren't reordered and haven't been retransmitted. This patch fixes this and allows the reassembly of messages regardless of retransmissions, losses, reordering or even the mixture of fragments of dif