Re: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Marshall Clow
On Jan 12, 2012, at 3:57 PM, Dave Thompson wrote: >> From: owner-openssl-...@openssl.org On Behalf Of Marshall Clow >> Sent: Thursday, 12 January, 2012 09:48 > >> On Jan 12, 2012, at 6:14 AM, Andy Polyakov via RT wrote: > >>> This actually goes beyond just warning. toupper accepts 'int' as >>> a

RE: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Dave Thompson
> From: owner-openssl-...@openssl.org On Behalf Of Marshall Clow > Sent: Thursday, 12 January, 2012 09:48 > On Jan 12, 2012, at 6:14 AM, Andy Polyakov via RT wrote: > > This actually goes beyond just warning. toupper accepts 'int' as > > argument and if you pass 'char' from upper half of ASCII ta

Re: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Marshall Clow
On Jan 12, 2012, at 8:44 AM, Andy Polyakov wrote: *** issue: extra warnings in compilation of ca.c and gost_pmeth solution: convert the type to unsigned int before "uppering" >>> This actually goes beyond just warning.

Re: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Andy Polyakov
>>> *** >>> issue: >>> extra warnings in compilation of ca.c and gost_pmeth >>> >>> solution: >>> convert the type to unsigned int before "uppering" >> This actually goes beyond just warning. toupper accepts 'int' as >> argument and if you pass 'char'

Re: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Andy Polyakov via RT
>> *** >> issue: >> extra warnings in compilation of ca.c and gost_pmeth >> >> solution: >> convert the type to unsigned int before "uppering" > > This means that *formally* speaking one should sanitize all references > to toupper/lower/isalpha and a

Re: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Marshall Clow
On Jan 12, 2012, at 6:14 AM, Andy Polyakov via RT wrote: >> *** >> issue: >> extra warnings in compilation of ca.c and gost_pmeth >> >> solution: >> convert the type to unsigned int before "uppering" > > This actually goes beyond just warning. tou

Re: [openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-12 Thread Andy Polyakov via RT
> *** > issue: > extra warnings in compilation of ca.c and gost_pmeth > > solution: > convert the type to unsigned int before "uppering" This actually goes beyond just warning. toupper accepts 'int' as argument and if you pass 'char' from upper half

[openssl.org #2682] 1.0.1-beta1 issue: compilation warnings warnings in compilation of ca.c and gost_pmeth

2012-01-08 Thread Annie Yousar via RT
*** issue: extra warnings in compilation of ca.c and gost_pmeth solution: convert the type to unsigned int before "uppering" patches: --- openssl-1.0.1-beta1/apps/ca.c 2011-10-10 01:13:45.0 +0200 +++ openssl-1.0.1-beta1.patch/apps/ca.c