RE: [openssl.org #2138] Resolved: [PATCH] Change needed for "-DPURIFY" builds.

2010-01-26 Thread Kevin Regan
Thanks you. --Kevin -Original Message- From: owner-openssl-...@openssl.org [mailto:owner-openssl-...@openssl.org] On Behalf Of Dr. Stephen Henson Sent: Tuesday, January 26, 2010 11:04 AM To: openssl-dev@openssl.org Subject: Re: [openssl.org #2138] Resolved: [PATCH] Change needed for

Re: [openssl.org #2138] Resolved: [PATCH] Change needed for "-DPURIFY" builds.

2010-01-26 Thread Dr. Stephen Henson
On Tue, Jan 26, 2010, Kevin Regan via RT wrote: > Is there somewhere that I can check to verify this? I want to make sure that > this patch is in the latest build. > You can either wait until tomorrow snapshots or pull the latest CVS using the information at: http://www.openssl.org//source/re

RE: [openssl.org #2138] Resolved: [PATCH] Change needed for "-DPURIFY" builds.

2010-01-26 Thread Kevin Regan via RT
: [openssl.org #2138] Resolved: [PATCH] Change needed for "-DPURIFY" builds. According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message. __ OpenS

[openssl.org #2138] [PATCH] Change needed for "-DPURIFY" builds.

2010-01-13 Thread Kevin Regan via RT
This patch fixes a bug with the -DPURIFY flag. The stat structure contains padding and unused fields that are not initialized with the stat call. This causes applications such as Valgrind to be unable to analyze OpenSSL executables that are compiled with the -DPURIFY flag. This is for OpenSSL

Re: [PATCH] Change needed for "-DPURIFY" builds.

2010-01-11 Thread Dr. Stephen Henson
On Mon, Jan 11, 2010, Kevin Regan wrote: > Hi Dr. Henson, > > I noticed instructions in the README to send the patch to the openssl-dev > mailing list. Where can I find this request tracker? > Sending it to rt-b...@openssl.org will result in it appearing in the request tracker. More details a

RE: [PATCH] Change needed for "-DPURIFY" builds.

2010-01-11 Thread Kevin Regan
Sent: Monday, January 11, 2010 4:35 PM To: openssl-dev@openssl.org Subject: Re: [PATCH] Change needed for "-DPURIFY" builds. On Mon, Jan 11, 2010, Kevin Regan wrote: > Any further thoughts on this patch? I'd love to get these -DPURIFY builds > working properly. > Plea

Re: [PATCH] Change needed for "-DPURIFY" builds.

2010-01-11 Thread Dr. Stephen Henson
On Mon, Jan 11, 2010, Kevin Regan wrote: > Any further thoughts on this patch? I'd love to get these -DPURIFY builds > working properly. > Please send the patch to the request tracker. Steve. -- Dr Stephen N. Henson. OpenSSL project core developer. Commercial tech support now available see: h

[PATCH] Change needed for "-DPURIFY" builds.

2010-01-11 Thread Kevin Regan
mp;sb,sizeof(sb),0.0); if (bytes == 0) return(ret); From: Kevin Regan Sent: Friday, January 08, 2010 11:01 AM To: Kevin Regan; 'openssl-dev@openssl.org' Subject: RE: RE: Change needed for "-DPURIFY" builds. I also wanted to mention that the -DPURIFY flag should not weake

RE: RE: Change needed for "-DPURIFY" builds.

2010-01-08 Thread Kevin Regan
. --Kevin From: Kevin Regan Sent: Friday, January 08, 2010 10:53 AM To: 'openssl-dev@openssl.org' Subject: RE: Change needed for "-DPURIFY" builds. >> You're missing the point -- your comment is the height of irony, in a >> way. >> >> Use a suppression

RE: Change needed for "-DPURIFY" builds.

2010-01-08 Thread Kevin Regan
>> You're missing the point -- your comment is the height of irony, in a >> way. >> >> Use a suppression to make Valgrind shut up. >> >> /r$ > > I think you misunderstand his issue. His issue is not "valgrind reports a > spurious error/warning". His issue is "-DPURIFY does not do what I thi

RE: Change needed for "-DPURIFY" builds.

2010-01-04 Thread David Schwartz
Allan K Pratt wrote: > EASY FIX: wherever RAND_add is defined (macro? function?), give it a > different body for -DPURIFY builds. When PURIFY is defined, don't use > the > memory being passed in at all. This sounds extreme, but it should work. > Sure, the entropy factors will change and the result

RE: Change needed for "-DPURIFY" builds.

2010-01-04 Thread Allan K Pratt
As a developer on the PurifyPlus product at IBM, I'd like to contribute a Purify usage note to this discussion. I see that the issue is RAND_add using whatever memory it's given (some of which can be uninitialized garbage) as entropy input for the random number generator. Tools like Purify repo

RE: Change needed for "-DPURIFY" builds.

2010-01-02 Thread David Schwartz
> You're missing the point -- your comment is the height of irony, in a > way. > > Use a suppression to make Valgrind shut up. > > /r$ I think you misunderstand his issue. His issue is not "valgrind reports a spurious error/warning". His issue is "-DPURIFY does not do what I think it's s

Re: Change needed for "-DPURIFY" builds.

2010-01-02 Thread Kurt Roeckx
On Sat, Jan 02, 2010 at 10:29:38AM -0500, Richard Salz wrote: > I took a closer look at current valgrind and the client requests. I > assume you mean doing something like this: > > if (VG_USERREQ__RUNNING_ON_VALGRIND) memset(&st, 0, sizeof st); > > It might be a nuisance to fix these, b

Re: Change needed for "-DPURIFY" builds.

2010-01-02 Thread Richard Salz
I took a closer look at current valgrind and the client requests. I assume you mean doing something like this: if (VG_USERREQ__RUNNING_ON_VALGRIND) memset(&st, 0, sizeof st); It might be a nuisance to fix these, but at least it keeps the code more correct. Right? (Separating valgrind

Re: Change needed for "-DPURIFY" builds.

2010-01-02 Thread Kurt Roeckx
On Fri, Jan 01, 2010 at 11:50:29PM -0500, Richard Salz wrote: > You're missing the point -- your comment is the height of irony, in a way. > > Use a suppression to make Valgrind shut up. Maybe you should try to suppress that in valgrind before telling us what to do. Try running a simple program

Re: Change needed for "-DPURIFY" builds.

2010-01-01 Thread Richard Salz
You're missing the point -- your comment is the height of irony, in a way. Use a suppression to make Valgrind shut up. /r$ -- STSM, WebSphere Appliance Architect https://www.ibm.com/developerworks/mydeveloperworks/blogs/soma/ _

Change needed for "-DPURIFY" builds.

2010-01-01 Thread Kevin Regan
The following patch is needed in order to allow applications such as Valgrind to work with "-DPURIFY" versions of openssl: crypto/rand/randfile.c : @@ -102,6 +102,14 @@ if (file == NULL) return(0); +#ifdef PURIFY +/* struct stat has padding and unused fields that may not be + *