Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-16 Thread Mike Frysinger
On Sunday 15 September 2013 18:30:32 Yuriy Kaminskiy wrote: > Cristian Rodríguez wrote: > > El 12/09/13 14:17, Yuriy Kaminskiy escribió: > >> This will break on glibc-3.0. > >> > >> #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 16) > > > > Yes, that is the correct way, but ensure is being inc

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-16 Thread Yuriy Kaminskiy
Cristian Rodríguez wrote: > El 12/09/13 14:17, Yuriy Kaminskiy escribió: > >> This will break on glibc-3.0. >> >> #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 16) > > Yes, that is the correct way, but ensure is being included. (it seems this patch will be rejected for different reasons anyw

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-13 Thread Mike Frysinger
On Friday 13 September 2013 16:27:03 Green, Paul wrote: > Cristian Rodríguez wrote: > > El 12/09/13 14:17, Yuriy Kaminskiy escribió: > >> This will break on glibc-3.0. > >> #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 16) > > > >Yes, that is the correct way, but ensure is being included. > >

RE: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-13 Thread Green, Paul
Cristian Rodríguez wrote: > El 12/09/13 14:17, Yuriy Kaminskiy escribió: > >> This will break on glibc-3.0. >> #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 16) > >Yes, that is the correct way, but ensure is being included. As a compiler implementer, I must object. The universal convention is

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-13 Thread Cristian Rodríguez
El 12/09/13 14:17, Yuriy Kaminskiy escribió: > This will break on glibc-3.0. > > #if defined(__GLIBC_PREREQ) && __GLIBC_PREREQ(2, 16) Yes, that is the correct way, but ensure is being included. __ OpenSSL Project

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-13 Thread Yuriy Kaminskiy
Kyle McMartin wrote: > More reliable than playing games with signal handling in libraries. > > --- a/crypto/armcap.c > +++ b/crypto/armcap.c > @@ -9,11 +9,6 @@ > > unsigned int OPENSSL_armcap_P; > > -static sigset_t all_masked; > - > -static sigjmp_buf ill_jmp; > -static void ill_handler (int

Re: [PATCH] armcap.c: use getauxv on glibc to find caps

2013-09-12 Thread Mike Frysinger
On Wednesday 11 September 2013 10:49:36 Kyle McMartin wrote: > +#if defined(__GNUC__) && __GNUC__>=2 > +void OPENSSL_cpuid_setup(void) __attribute__((constructor)); > +#endif > +void OPENSSL_cpuid_setup(void) this can be made simpler: #if defined(__GNUC__) && __GNUC__>=2 __attribut