Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-07 Thread Kurt Roeckx
On Sat, Jun 07, 2014 at 11:06:56AM -0400, Salz, Rich wrote: > > And I want to reduce the number of exposed APIs. > > Except that as we (hopefully) move to making struct's opaque, then we'll need > add lots of accessors. I assume you know that, but just want to make sure > folks realize it. Tho

RE: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-07 Thread Salz, Rich
> And I want to reduce the number of exposed APIs. Except that as we (hopefully) move to making struct's opaque, then we'll need add lots of accessors. I assume you know that, but just want to make sure folks realize it. In the medium term, I'd like to see things like this "BN foo;" break at c

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-07 Thread Kurt Roeckx
On Sat, Jun 07, 2014 at 09:46:38AM -0400, Mike Bland wrote: > > Why do any of the symbols need to be private? Is that degree of > encapsulation necessary, and does it really discourage irresponsible > clients? The source code is open, so people can always build their own > copy and depend on inter

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-07 Thread Mike Bland
Before this goes in, I'm going to take this opportunity to raise a question that I've documented on the wiki (which came up in a discussion off-list): http://wiki.openssl.org/index.php/Unit_Testing#How_to_Manage_Private_Symbols Why do any of the symbols need to be private? Is that degree of encap

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-07 Thread Kurt Roeckx via RT
On Thu, Jun 05, 2014 at 11:59:30PM +0200, Matt Caswell via RT wrote: > On Thu Jun 05 23:42:31 2014, k...@roeckx.be wrote: > > > > > We are likely to see > > > a lot more like this as Mike's test team get going. In unit testing > > its "okay" > > > to access internal symbols. > > > > But then you sh

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-07 Thread Kurt Roeckx
On Thu, Jun 05, 2014 at 11:59:30PM +0200, Matt Caswell via RT wrote: > On Thu Jun 05 23:42:31 2014, k...@roeckx.be wrote: > > > > > We are likely to see > > > a lot more like this as Mike's test team get going. In unit testing > > its "okay" > > > to access internal symbols. > > > > But then you sh

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-05 Thread Kurt Roeckx via RT
On Thu, Jun 05, 2014 at 11:34:15PM +0200, Matt Caswell via RT wrote: > On Thu Jun 05 20:41:05 2014, k...@roeckx.be wrote: > > This is probably related to me not exporting those symbols as they are > > marked local. > > Kurt > > Is this related to the way you build the Debian packages? Yes. And

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-05 Thread Kurt Roeckx
On Thu, Jun 05, 2014 at 11:34:15PM +0200, Matt Caswell via RT wrote: > On Thu Jun 05 20:41:05 2014, k...@roeckx.be wrote: > > This is probably related to me not exporting those symbols as they are > > marked local. > > Kurt > > Is this related to the way you build the Debian packages? Yes. And

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-05 Thread Kurt Roeckx
On Thu, Jun 05, 2014 at 03:01:47PM -0400, Mike Bland wrote: > On Thu, Jun 5, 2014 at 2:41 PM, Kurt Roeckx via RT wrote: > > Hi, > > > > When building the 1.0.1h release I got this error: > > heartbeat_test.o: In function `set_up': > > test/heartbeat_test.c:94: undefined reference to `ssl_init_wbio

Re: [openssl.org #3378] heartbeat_test: Using internal APIs

2014-06-05 Thread Mike Bland
On Thu, Jun 5, 2014 at 2:41 PM, Kurt Roeckx via RT wrote: > Hi, > > When building the 1.0.1h release I got this error: > heartbeat_test.o: In function `set_up': > test/heartbeat_test.c:94: undefined reference to `ssl_init_wbio_buffer' > test/heartbeat_test.c:102: undefined reference to `ssl3_setup