Re: [openssl.org #3505] rewrite c_rehash in C

2014-10-22 Thread Mike Frysinger
On 26 Aug 2014 19:44, Timo Teras wrote: > On Tue, 26 Aug 2014 10:12:06 -0400 "Salz, Rich" wrote: > > > Find a C version (which I have written) of the utility at: > > > http://git.alpinelinux.org/cgit/aports/plain/main/openssl/c_rehash.c > > > > That's pretty cool. We'd need to modify it to not us

RE: [openssl.org #3505] rewrite c_rehash in C

2014-10-01 Thread Salz, Rich
Great work! -- Principal Security Engineer, Akamai Technologies IM: rs...@jabber.me Twitter: RichSalz

Re: [openssl.org #3505] rewrite c_rehash in C

2014-10-01 Thread Timo Teräs via RT
Updated c_rehash.c based on feed back from the mailing list and Rich Salz. Would be nice to get additional review. It is not yet a patch for 'openssl' subcommand, but this is on the list. Just posting current progress. Most notable changes: - removal of non-portable libc usage such as fnmatch(),

RE: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Salz, Rich
BTW, as you work on this, also take a look at RT items 2272 and 2973 :) __ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated Lis

Re: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Viktor Dukhovni
On Tue, Aug 26, 2014 at 08:25:15PM +0300, Timo Teras wrote: > > The algorithm should be improved to never delete links which are > > subsequently recreated. > > I almost answered "it's fixed". But it's not. IIRC, the version had it > fixed, but it did not handle hash collisions nicely. This certa

Re: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Timo Teras
On Tue, 26 Aug 2014 17:19:24 + Viktor Dukhovni wrote: > On Tue, Aug 26, 2014 at 10:12:06AM -0400, Salz, Rich wrote: > > > > Find a C version (which I have written) of the utility at: > > > http://git.alpinelinux.org/cgit/aports/plain/main/openssl/c_rehash.c > > > > That's pretty cool. We'd

Re: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Viktor Dukhovni
On Tue, Aug 26, 2014 at 10:12:06AM -0400, Salz, Rich wrote: > > Find a C version (which I have written) of the utility at: > > http://git.alpinelinux.org/cgit/aports/plain/main/openssl/c_rehash.c > > That's pretty cool. We'd need to modify it to not use the XXXat > functions or fnmatch, but defi

Re: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Timo Teras
On Tue, 26 Aug 2014 10:12:06 -0400 "Salz, Rich" wrote: > > Find a C version (which I have written) of the utility at: > > http://git.alpinelinux.org/cgit/aports/plain/main/openssl/c_rehash.c > > That's pretty cool. We'd need to modify it to not use the XXXat > functions or fnmatch, but definite

Re: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Timo Teras
On Tue, 26 Aug 2014 12:50:49 -0400 "Salz, Rich" wrote: > Don't rush. It'll be a while until (or if) we switch over. Neat job > tho. Perhaps it should be merged into the openssl command? > (see https://github.com/akamai/openssl/tree/rsalz-monolith) I wrote the code about 8 months ago - and did

RE: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Salz, Rich
Don't rush. It'll be a while until (or if) we switch over. Neat job tho. Perhaps it should be merged into the openssl command? (see https://github.com/akamai/openssl/tree/rsalz-monolith) -- Principal Security Engineer Akamai Technologies, Cambridge MA IM: rs...@jabber.me Twitter: RichSalz ___

RE: [openssl.org #3505] rewrite c_rehash in C

2014-08-26 Thread Salz, Rich
> Find a C version (which I have written) of the utility at: > http://git.alpinelinux.org/cgit/aports/plain/main/openssl/c_rehash.c That's pretty cool. We'd need to modify it to not use the XXXat functions or fnmatch, but definitely something we should consider for a future release. -- Princ