Please don’t automatically drop the "appoval: done" label after a comment. I
feel that is not uncommon for comments to be added that in no way invalidate
the approval.
I agree with not switching to “ready to merge” if there are comments — manual
intervention in this case is required to judge
Thanks Dmitry; I hope that the comment triggers notifications to the
creator without mentioning them? (let me know if you get something
changed labels that doesn't) Mark
On Sat, Feb 8, 2020 at 4:57 PM Dmitry Belyavsky wrote:
>
> Dear Mark,
>
> Thank you for a nice job!
>
> As the reviewers
Dear Mark,
Thank you for a nice job!
As the reviewers are expected to commit the PRs, could you also add the
reviewers' names as a part of the notification?
On Sat, Feb 8, 2020 at 6:56 PM Mark J Cox wrote:
> I've currently got a cron job running every hour that looks at open PR
> requests