On 08/02/2020 15:56, Mark J Cox wrote:
> I've currently got a cron job running every hour that looks at open PR
> requests against github openssl repo and does various actions. So if
> you were wondering why I was altering labels and making comments at
> 4am, now you know. No doubt we'll use s
Please don’t automatically drop the "appoval: done" label after a comment. I
feel that is not uncommon for comments to be added that in no way invalidate
the approval.
I agree with not switching to “ready to merge” if there are comments — manual
intervention in this case is required to judge t
> -Original Message-
> From: openssl-project On Behalf Of Mark
> J Cox
> Sent: Saturday, February 8, 2020 8:52 PM
> To: Dmitry Belyavsky
> Cc: openssl-project@openssl.org
> Subject: Re: Github PR label automation
>
> Thanks Dmitry; I hope that the comment triggers notifications to the
First of all, thank you Mark for implementing the notification daemon. You did
a great job
and I think it's very useful. Here are some comments and thoughts about your
last mail.
> No doubt we'll use some tool user for this in the future.
Can't you just use an API-token generated for the opens
Thanks Dmitry; I hope that the comment triggers notifications to the
creator without mentioning them? (let me know if you get something
changed labels that doesn't) Mark
On Sat, Feb 8, 2020 at 4:57 PM Dmitry Belyavsky wrote:
>
> Dear Mark,
>
> Thank you for a nice job!
>
> As the reviewers are
Dear Mark,
Thank you for a nice job!
As the reviewers are expected to commit the PRs, could you also add the
reviewers' names as a part of the notification?
On Sat, Feb 8, 2020 at 6:56 PM Mark J Cox wrote:
> I've currently got a cron job running every hour that looks at open PR
> requests agai
I've currently got a cron job running every hour that looks at open PR
requests against github openssl repo and does various actions. So if
you were wondering why I was altering labels and making comments at
4am, now you know. No doubt we'll use some tool user for this in the
future.
So right no
