Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread Yuriy Taraday
Thanks to he fix, invalid author problem vanished. Now I'm getting missing Change-Id in commit message error. What is the best way to provide Change-Id to existing commits? Kind regards, Yuriy. On Wed, Aug 3, 2011 at 18:58, James E. Blair cor...@inaugust.com wrote: Yuriy Taraday

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread James E. Blair
Yuriy Taraday yorik@gmail.com writes: Thanks to he fix, invalid author problem vanished. Now I'm getting missing Change-Id in commit message error. What is the best way to provide Change-Id to existing commits? Kind regards, Yuriy. We've seen two ways of getting commits without

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread James E. Blair
cor...@inaugust.com (James E. Blair) writes: I'll work on updating our import script to fix the rest of the accounts and send out another email to this list when that is complete. Monty has fixed the Launchpad sync script so that publicly available emails should correctly show up in Gerrit

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread Brad Hall
If your commit doesn't have a change-id message you can add one by amending the commit (git commit --amend) as long as you have the commit-msg hook in place and executable. (See here for more details: http://wiki.openstack.org/GerritWorkflow) This page doesn't mention it but you need to chmod +x

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread Trey Morris
I had to register my git email with gerrit as well, no problems after. If you do a git commit --amend will the hook add the change-id after you edit the commit message? I ask because it didn't when doing an interactive rebase. I did it this morning but I pasted the change-id in myself. -trey On

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread Brad Hall
I'm not sure about during an interactive rebase .. I've always just done the amend before or after the rebase and the changeid will get added if it isn't already there. Thanks, Brad On Thu, Aug 4, 2011 at 9:16 AM, Trey Morris trey.mor...@rackspace.com wrote: I had to register my git email with

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread Yuriy Taraday
I have series of commits that can be applied separately and can be treated as separate improvements in my branch. That commits were there before I knew that I should install Gerrit hook. Now I have bunch of commits without Change-Id while commit --amend works only with the last one. How can I edit

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-04 Thread James E. Blair
Yuriy Taraday yorik@gmail.com writes: I have series of commits that can be applied separately and can be treated as separate improvements in my branch. That commits were there before I knew that I should install Gerrit hook. Now I have bunch of commits without Change-Id while commit

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-03 Thread Dolph Mathews
Taraday [yorik@gmail.com] Sent: Wednesday, August 03, 2011 7:50 AM To: openstack@lists.launchpad.net Subject: [Openstack] [Gerrit] Getting invalid author Hello. I'm trying to use Gerrit to propose changes to Keystone. I'm using instructions from http://wiki.openstack.org/GerritWorkflow to push my

Re: [Openstack] [Gerrit] Getting invalid author

2011-08-03 Thread James E. Blair
Yuriy Taraday yorik@gmail.com writes: Hello. I'm trying to use Gerrit to propose changes to Keystone. I'm using instructions from http://wiki.openstack.org/GerritWorkflow to push my changes. I'm getting invalid author error but my settings/contacts page looks fine and the e-mail listed