Hi Andy,
On 2012-03-22, at 10:00 PM, Andy Smith wrote:
> The rule is there because it makes it obvious where you are using objects
> from (and they aren't in the current namespace), prevents that "where is this
> defined -scan around the file- oh, it is being imported from this other
> thing,
On Fri, Mar 23, 2012 at 1:17 PM, Mark McLoughlin wrote:
> On Thu, 2012-03-22 at 22:00 -0700, Andy Smith wrote:
>
> > It is something pulled from the google style guide.
>
> You know what else is in the Google style guide? "Avoid global
> variables" :-)
>
>
> http://google-styleguide.googlecode.co
On Thu, 2012-03-22 at 22:00 -0700, Andy Smith wrote:
> It is something pulled from the google style guide.
You know what else is in the Google style guide? "Avoid global
variables" :-)
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Global_variables#Global_variables
Mark.
On Fri, 2012-03-23 at 11:18 -0500, Andrew Bogott wrote:
> 1) I can back out my new style-guide from openstack-common
openstack-common still needs a HACKING file for itself :)
Cheers,
Mark.
___
Mailing list: https://launchpad.net/~openstack
Post to
>
>
> I am happy to take on and implement any of these approaches, up to and
> including scheduling an in-person Code Summit Battledome in order to
> resolve differences of opinion about docstring whitespace. But, my
> preference for a unified style-guide is a mild one, and I'll probably just
> op
On 03/23/2012 12:18 PM, Andrew Bogott wrote:
OK, so I see three ways of going forward here.
1) I can back out my new style-guide from openstack-common, and add my
new encoding rule to each project guide.
This seems good to me.
-jay
___
Mailing list
OK, so I see three ways of going forward here.
1) I can back out my new style-guide from openstack-common, and add my
new encoding rule to each project guide.
2) We can modify each project-specific guide so that it's
supplemental. "Follow the common style guide, but with the following
exc
On Thu, Mar 22, 2012 at 4:26 PM, Maru Newby wrote:
> Hi Jay,
>
> On 2012-03-22, at 2:13 PM, Jay Pipes wrote:
>
>
> Object Imports
> ==
>
> In addition, the following DOES NOT appear in Glance's section on imports:
>
> - Do not import objects, only modules
>
> Nowhere in PEP8 does it m
Hi Jay,
On 2012-03-22, at 2:13 PM, Jay Pipes wrote:
>
> Object Imports
> ==
>
> In addition, the following DOES NOT appear in Glance's section on imports:
>
> - Do not import objects, only modules
>
> Nowhere in PEP8 does it mention anything about not importing objects. In
> fact,
Oh, and we should include the file in each project with a link to whatever
the base one is.
That said, I don't intend to change the style of my project just because
the common one changes, and it shouldn't be a wiki because that makes it
too easy to change.
On Thu, Mar 22, 2012 at 3:01 PM, Andy S
On Thu, Mar 22, 2012 at 9:22 AM, Andrew Bogott wrote:
>Just now I set out to merge a recent style guide change from
> python-novaclient into the hacking docs of other OpenStack projects. My
> patch didn't apply, though, because each project has subtly diverging
> HACKING files.
>
>Rather
On Thu, Mar 22, 2012 at 4:22 PM, Jay Pipes wrote:
> On 03/22/2012 01:47 PM, Doug Hellmann wrote:
>
>> Why are those sorts of instructions replicated in each project in the
>> first place? Shouldn't they be in the wiki?
>>
>
> :) Have you ever tried to get a dozen OpenStack contributors to agree o
(in a thundering voice)
Release the Kraken!
On 03/22/2012 12:22 PM, Andrew Bogott wrote:
Just now I set out to merge a recent style guide change from
python-novaclient into the hacking docs of other OpenStack projects. My
patch didn't apply, though, because each project has subtly diverging
HAC
On 03/22/2012 01:47 PM, Doug Hellmann wrote:
Why are those sorts of instructions replicated in each project in the
first place? Shouldn't they be in the wiki?
:) Have you ever tried to get a dozen OpenStack contributors to agree
on, well, anything?
The reason it's duplicated in so many place
On 03/22/2012 10:47 AM, Doug Hellmann wrote:
Why are those sorts of instructions replicated in each project in the
first place? Shouldn't they be in the wiki?
Because nobody reads wikis. Especially not developers who are in a hurry
to make a small fix. At least this way, we can yell at them an
On Thu, 2012-03-22 at 13:47 -0400, Doug Hellmann wrote:
> Why are those sorts of instructions replicated in each project in the
> first place? Shouldn't they be in the wiki?
Well, you're both right and wrong. Right in that they should be in a
wiki somewhere. Wrong in that they should *also* be i
On Thu, Mar 22, 2012, Kevin L. Mitchell wrote:
> On Thu, 2012-03-22 at 11:22 -0500, Andrew Bogott wrote:
> > Nova, this:
> >
> >A docstring ends with an empty line before the closing quotations.
>
> Huh? I thought I removed that...
You did:
https://github.com/openstack/nova/commit/35e98d
> Sent: Thursday, March 22, 2012 9:22 AM
> To: openstack@lists.launchpad.net
> Subject: [Openstack] Being pedantic about pedanticism: HACKING
> styleguide
>
> Just now I set out to merge a recent style guide change from
> python-novaclient into the hacking docs of other
Why are those sorts of instructions replicated in each project in the first
place? Shouldn't they be in the wiki?
On Thu, Mar 22, 2012 at 12:22 PM, Andrew Bogott wrote:
>Just now I set out to merge a recent style guide change from
> python-novaclient into the hacking docs of other OpenStack p
On Thu, Mar 22, 2012, Andrew Bogott wrote:
> I propose that this unified style guide be copied into each of
> the above projects, with a mandate to maintain consistency
> henceforth. Any objections?
I recently saw a suggestion to put it into openstack-common, but I don't
remember who made it
On Thu, 2012-03-22 at 11:22 -0500, Andrew Bogott wrote:
> Nova, this:
>
>A docstring ends with an empty line before the closing quotations.
Huh? I thought I removed that...
--
Kevin L. Mitchell
___
Mailing list: https://launchpad.net/~openstac
Just now I set out to merge a recent style guide change from
python-novaclient into the hacking docs of other OpenStack projects. My
patch didn't apply, though, because each project has subtly diverging
HACKING files.
Rather than contribute to this divergence, I've now read and
compa
22 matches
Mail list logo
