[Openstack] Marking 'Approved' with others who say 'Needs Fixing'

2011-08-23 Thread Brian Lamar
I see this happening more and more when deadlines are coming up: There is a merge proposal which has 2+ Core Approvals and 1+ Core Needs Fixings and the branch is marked as 'Approved'. This is fine, in my opinion, if you've talked to the person and they have given verbal approval or if the

Re: [Openstack] Marking 'Approved' with others who say 'Needs Fixing'

2011-08-23 Thread Jay Pipes
++ On Tue, Aug 23, 2011 at 10:06 AM, Brian Lamar brian.la...@rackspace.com wrote: I see this happening more and more when deadlines are coming up: There is a merge proposal which has 2+ Core Approvals and 1+ Core Needs Fixings and the branch is marked as 'Approved'. This is fine, in my