Re: [openstack-dev] [horizon] function expressions vs function declarations in JavaScript

2015-01-15 Thread Aaron Sahlin
Just to expand a bit on Thai's response.. Make the changes to horizon/doc/source/contributing.rst and submit a patch, once that gets approval then go update the wiki. On 1/14/2015 3:49 PM, Thai Q Tran wrote: Wow, that IS interesting. No process required, just modify /horizon/doc/source/con

Re: [openstack-dev] [horizon] [ux] Changing how the modals are closed in Horizon

2014-12-04 Thread Aaron Sahlin
g both patches together (perhaps, changing a bit David's js-code for catching 'click' event - to work only for the modal forms with [data-modal-backdrop='confirm']). On Thu, Dec 4, 2014 at 1:30 AM, Aaron Sahlin mailto:asah...@linux.vnet.ibm.com>> wrote: I wo

Re: [openstack-dev] [horizon] [ux] Changing how the modals are closed in Horizon

2014-12-03 Thread Aaron Sahlin
I would be happy with either the two proposed solutions (both improvements over the what we have now). Any thoughts on combining them? Only close if esc or 'x' is clicked, but also warn them if data was entered. On 12/3/2014 7:21 AM, Rob Cresswell (rcresswe) wrote: +1 to changing the behavi

[openstack-dev] [Horizon] Cookie collision between Horizon & Stacktach

2014-10-31 Thread Aaron Sahlin
I was posed this question, but am not familiar with Horizon or StackTach cookie management. Anyone know what the issue might be? Issue: Logging into one site logs you out of the other. (horizon/stacktach) First I open horizon and notice there are two cookies: csrftoken (horizon) and sessi

Re: [openstack-dev] [Horizon] Licensing issue with using JSHint in build

2014-09-10 Thread Aaron Sahlin
What you are finding is the same as I found, which raised my concern. Thanks for the pointer to legal-disc...@lists.openstack.org, I will post the question there (let the lawyers figure it out). On 9/10/2014 12:16 PM, Solly Ross wrote: - Original Message - From: "Jeremy Stanley"

[openstack-dev] [Horizon] Licensing issue with using JSHint in build

2014-09-10 Thread Aaron Sahlin
I noticed that the build is using JSHint now, and before I consider syncing it with the proposed options from the JavaScript best practices (https://review.openstack.org/#/c/117595/), I wanted to double check and be sure Horizon got past the legal problem with the good/evil licensing. Some bac