Re: [openstack-dev] Criteria for giving a -1 in a review

2014-08-22 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 04:52:37PM -0500, Dolph Mathews wrote: > On Thu, Aug 21, 2014 at 11:53 AM, Daniel P. Berrange > wrote: > > > On Thu, Aug 21, 2014 at 11:34:48AM -0500, Dolph Mathews wrote: > > > On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange < > >

Re: [openstack-dev] [nova][libvirt] Non-readonly connection to libvirt in unit tests

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 12:23:12PM -0500, Matt Riedemann wrote: > > > On 8/21/2014 11:37 AM, Clark Boylan wrote: > > > > > >On Thu, Aug 21, 2014, at 09:25 AM, Matt Riedemann wrote: > >> > >> > >>On 8/21/2014 10:23 AM, Daniel P. Berrange wrote

Re: [openstack-dev] Criteria for giving a -1 in a review

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 01:12:16PM -0400, Zane Bitter wrote: > On 21/08/14 12:21, Daniel P. Berrange wrote: > >On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote: > >>>"I would prefer that you didn't merge this." > >>> > >>>i

Re: [openstack-dev] Criteria for giving a -1 in a review

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 12:40:59PM -0400, Adam Young wrote: > On 08/21/2014 12:21 PM, Daniel P. Berrange wrote: > >On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote: > >>"I would prefer that you didn't merge this." > >> > >>i.e. The p

Re: [openstack-dev] Criteria for giving a -1 in a review

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 12:42:43PM -0400, Adam Young wrote: > On 08/21/2014 12:34 PM, Dolph Mathews wrote: > > > >On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange ><mailto:berra...@redhat.com>> wrote: > > > >On Thu, Aug 21, 2014 at 05:05:04PM +0100,

Re: [openstack-dev] Criteria for giving a -1 in a review

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 11:34:48AM -0500, Dolph Mathews wrote: > On Thu, Aug 21, 2014 at 11:21 AM, Daniel P. Berrange > wrote: > > > On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote: > > > "I would prefer that you didn't merge this." >

Re: [openstack-dev] Criteria for giving a -1 in a review

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote: > "I would prefer that you didn't merge this." > > i.e. The project is better off without it. A bit off topic, but I've never liked this message that gets added as it think it sounds overly negative. It would better written as "Thi

Re: [openstack-dev] [nova][libvirt] Non-readonly connection to libvirt in unit tests

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 11:14:33AM -0400, Solly Ross wrote: > (reply inline) > > - Original Message - > > From: "Daniel P. Berrange" > > To: "OpenStack Development Mailing List (not for usage questions)" > > > > Sent: Thursday, Au

Re: [openstack-dev] New feature on Nova

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 05:00:59PM +0200, thomas.pessi...@orange.com wrote: > Hello, > > Sorry if I am not on the right mailing list. I would like to get some > information. > > I would like to know if I am a company who wants to add a feature on > an openstack module. How do we have to proceed ?

Re: [openstack-dev] [nova][libvirt] Non-readonly connection to libvirt in unit tests

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 10:52:42AM -0400, Solly Ross wrote: > FYI, the context of this is that I would like to be able to test some > of the libvirt storage pool code against a live file system, as we > currently test the storage pool code. To do this, we need at least to > be able to get a prope

Re: [openstack-dev] [nova] Prioritizing review of potentially "approvable" patches

2014-08-21 Thread Daniel P. Berrange
On Thu, Aug 21, 2014 at 08:26:29AM -0500, Matt Riedemann wrote: > > > On 8/21/2014 7:09 AM, Sean Dague wrote: > >FWIW, this is one of my normal morning practices, and the reason that > >that query is part of most of the gerrit dashboards - > >https://github.com/stackforge/gerrit-dash-creator/blob

[openstack-dev] [nova] Prioritizing review of potentially "approvable" patches

2014-08-21 Thread Daniel P. Berrange
Tagged with '[nova]' but this might be relevant data / idea for other teams too. With my code contributor hat on, one of the things that I find most the frustrating about Nova code review process is that a patch can get a +2 vote from one core team member and then sit around for days, weeks, even

Re: [openstack-dev] [nova][neutron] Migration from nova-network to Neutron for large production clouds

2014-08-21 Thread Daniel P. Berrange
On Wed, Aug 20, 2014 at 03:17:40PM +, Tim Bell wrote: > Michael has been posting very informative blogs on the summary of > the mid-cycle meetups for Nova. The one on the Nova Network to > Neutron migration was of particular interest to me as it raises a > number of potential impacts for the CE

Re: [openstack-dev] [Nova] Scheduler split wrt Extensible Resource Tracking

2014-08-20 Thread Daniel P. Berrange
On Wed, Aug 20, 2014 at 08:33:31AM -0400, Jay Pipes wrote: > On 08/20/2014 04:48 AM, Nikola Đipanov wrote: > >On 08/20/2014 08:27 AM, Joe Gordon wrote: > >>On Aug 19, 2014 10:45 AM, "Day, Phil" >>> wrote: > >>> > -Original Message- > From: Nikola Đipanov [

Re: [openstack-dev] Using gerrymander, a client API and command line tool for gerrit

2014-08-20 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 05:54:27PM +0100, Daniel P. Berrange wrote: > > In terms of how I personally use it (assuming the above config file)... > Vish pointed out that I made a bunch of stupid typos in my examples here. Next time I'll actually double-check what I write :-) >

Re: [openstack-dev] [TripleO] Specs and approvals

2014-08-19 Thread Daniel P. Berrange
On Tue, Aug 19, 2014 at 09:31:48PM +1200, Robert Collins wrote: > Hey everybody - https://wiki.openstack.org/wiki/TripleO/SpecReviews > seems pretty sane as we discussed at the last TripleO IRC meeting. > > I'd like to propose that we adopt it with the following tweak: > > 19:46:34 so I propose

Re: [openstack-dev] [All] LOG.warning/LOG.warn

2014-08-18 Thread Daniel P. Berrange
On Mon, Aug 18, 2014 at 11:27:39AM -0400, Doug Hellmann wrote: > > On Aug 18, 2014, at 10:15 AM, Daniel P. Berrange wrote: > > > On Mon, Aug 18, 2014 at 07:57:28AM +1000, Michael Still wrote: > >> My recollection is that this was a request from the oslo team, but it >

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-18 Thread Daniel P. Berrange
On Mon, Aug 18, 2014 at 11:18:52AM -0400, Russell Bryant wrote: > On 08/18/2014 06:18 AM, Thierry Carrez wrote: > > Doug Hellmann wrote: > >> On Aug 13, 2014, at 4:42 PM, Russell Bryant wrote: > >>> Let me try to say it another way. You seemed to say that it wasn't much > >>> to ask given the rat

Re: [openstack-dev] [All] LOG.warning/LOG.warn

2014-08-18 Thread Daniel P. Berrange
On Mon, Aug 18, 2014 at 07:57:28AM +1000, Michael Still wrote: > My recollection is that this was a request from the oslo team, but it > was so long ago that I don't recall the details. > > I think the change is low value, so should only be done when someone > is changing the logging in a file alr

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-18 Thread Daniel P. Berrange
On Mon, Aug 18, 2014 at 12:18:16PM +0200, Thierry Carrez wrote: > Doug Hellmann wrote: > > On Aug 13, 2014, at 4:42 PM, Russell Bryant wrote: > >> Let me try to say it another way. You seemed to say that it wasn't much > >> to ask given the rate at which things happen in OpenStack. I would > >>

[openstack-dev] [nova] running pep8 tests much faster

2014-08-18 Thread Daniel P. Berrange
We recently had a change merged to the run_tests.sh script that Nova developers would really benefit from knowing about: https://review.openstack.org/#/c/110746/ Basically, it provides a way to run the pep8 tests *only* against the files which you have actually touched in your patch. For most

Re: [openstack-dev] [neutron][ml2] Mech driver as out-of-tree add-on

2014-08-15 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 12:09:26PM +0200, Salvatore Orlando wrote: > I think there will soon be a discussion regarding what the appropriate > location for plugin and drivers should be. > My personal feeling is that Neutron has simply reached the tipping point > where the high number of drivers and

Re: [openstack-dev] [nova] Review priorities as we approach juno-3

2014-08-15 Thread Daniel P. Berrange
On Fri, Aug 15, 2014 at 06:53:41AM +1000, Michael Still wrote: > On Fri, Aug 15, 2014 at 6:37 AM, Dan Smith wrote: > >> == Move Virt Drivers to use Objects (Juno Work) == > >> > >> I couldn't actually find any code out for review for this one apart > >> from https://review.openstack.org/#/c/94477/

[openstack-dev] Using gerrymander, a client API and command line tool for gerrit

2014-08-14 Thread Daniel P. Berrange
Over the past couple of months I've worked on creating a python library and command line tool for dealing with gerrit. I've blogged about this a number of times on http://planet.openstack.org, but I figure there are quite a few people who won't be reading the blogs there or easily miss some posts h

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-14 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 10:30:59AM -0500, Kyle Mestery wrote: > On Thu, Aug 14, 2014 at 10:13 AM, Sandy Walsh > wrote: > > On 8/14/2014 11:28 AM, Russell Bryant wrote: > >> On 08/14/2014 10:04 AM, CARVER, PAUL wrote: > >>> Daniel P. Berrange [

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-14 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 08:31:48AM -0400, Russell Bryant wrote: > On 08/13/2014 11:31 PM, Michael Still wrote: > > On Thu, Aug 14, 2014 at 1:24 PM, Jay Pipes wrote: > > > >> Just wanted to quickly weigh in with my thoughts on this important topic. I > >> very much valued the face-to-face interact

Re: [openstack-dev] [nova] Retrospective veto revert policy

2014-08-14 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 10:06:13AM +0100, Mark McLoughlin wrote: > On Tue, 2014-08-12 at 15:56 +0100, Mark McLoughlin wrote: > > Hey > > > > (Terrible name for a policy, I know) > > > > From the version_cap saga here: > > > > https://review.openstack.org/110754 > > > > I think we need a bette

Re: [openstack-dev] [all] 3rd Party CI vs. Gerrit

2014-08-14 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 12:05:27PM -0700, James E. Blair wrote: > cor...@inaugust.com (James E. Blair) writes: > > > Sean Dague writes: > > > >> This has all gone far enough that someone actually wrote a Grease Monkey > >> script to purge all the 3rd Party CI content out of Jenkins UI. People > >

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-14 Thread Daniel P. Berrange
On Thu, Aug 14, 2014 at 09:24:36AM +1000, Michael Still wrote: > On Thu, Aug 14, 2014 at 3:09 AM, Dan Smith wrote: > >> I'm not questioning the value of f2f - I'm questioning the idea of > >> doing f2f meetings sooo many times a year. OpenStack is very much > >> the outlier here among open source

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 09:18:09AM -0700, Maru Newby wrote: > > On Aug 13, 2014, at 2:57 AM, Daniel P. Berrange wrote: > > > On Wed, Aug 13, 2014 at 08:57:40AM +1000, Michael Still wrote: > >> Hi. > >> > >> One of the action items from the nova midcycl

Re: [openstack-dev] Fwd: [nova][core] Expectations of core reviewers

2014-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 09:01:59AM -0700, Maru Newby wrote: > > On Aug 13, 2014, at 2:57 AM, Daniel P. Berrange wrote: > > > On Wed, Aug 13, 2014 at 08:57:40AM +1000, Michael Still wrote: > >> Hi. > >> > >> One of the action items from the nova midcycl

Re: [openstack-dev] [nova] so what do i do about libvirt-python if i'm on precise?

2014-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 04:24:57PM +0100, Mark McLoughlin wrote: > On Wed, 2014-08-13 at 10:26 +0100, Daniel P. Berrange wrote: > > On Tue, Aug 12, 2014 at 10:09:52PM +0100, Mark McLoughlin wrote: > > > On Wed, 2014-07-30 at 15:34 -0700, Clark Boylan wrote: > > > >

Re: [openstack-dev] [all] The future of the integrated release

2014-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 09:11:26AM -0400, Russell Bryant wrote: > On 08/13/2014 08:52 AM, Mark McLoughlin wrote: > > On Tue, 2014-08-12 at 14:26 -0400, Eoghan Glynn wrote: > >> > It seems like this is exactly what the slots give us, though. The core > >> review > >>> team picks a number of slots

Re: [openstack-dev] [all] The future of the integrated release

2014-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 12:55:48PM +0100, Steven Hardy wrote: > On Wed, Aug 13, 2014 at 11:42:52AM +0100, Daniel P. Berrange wrote: > > On Thu, Aug 07, 2014 at 03:56:04AM -0700, Jay Pipes wrote: > > > That said, I entirely agree with you and wish efforts to stabilize would >

Re: [openstack-dev] [all] The future of the integrated release

2014-08-13 Thread Daniel P. Berrange
On Thu, Aug 07, 2014 at 03:56:04AM -0700, Jay Pipes wrote: > On 08/07/2014 02:12 AM, Kashyap Chamarthy wrote: > >On Thu, Aug 07, 2014 at 07:10:23AM +1000, Michael Still wrote: > >>On Wed, Aug 6, 2014 at 2:03 AM, Thierry Carrez > >>wrote: > >> > >>>We seem to be unable to address some key issues i

Re: [openstack-dev] [all] The future of the integrated release

2014-08-13 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 10:30:12PM -0700, Joe Gordon wrote: > On Fri, Aug 8, 2014 at 6:58 AM, Kyle Mestery wrote: > > > I really like this idea, as Michael and others alluded to in above, we > > are > > > attempting to set cycle goals for Kilo in Nova. but I think it is worth > > > doing for all o

Re: [openstack-dev] [nova][core] Expectations of core reviewers

2014-08-13 Thread Daniel P. Berrange
On Wed, Aug 13, 2014 at 08:57:40AM +1000, Michael Still wrote: > Hi. > > One of the action items from the nova midcycle was that I was asked to > make nova's expectations of core reviews more clear. This email is an > attempt at that. > > Nova expects a minimum level of sustained code reviews fro

Re: [openstack-dev] [nova] so what do i do about libvirt-python if i'm on precise?

2014-08-13 Thread Daniel P. Berrange
On Tue, Aug 12, 2014 at 10:09:52PM +0100, Mark McLoughlin wrote: > On Wed, 2014-07-30 at 15:34 -0700, Clark Boylan wrote: > > On Wed, Jul 30, 2014, at 03:23 PM, Jeremy Stanley wrote: > > > On 2014-07-30 13:21:10 -0700 (-0700), Joe Gordon wrote: > > > > While forcing people to move to a newer versio

Re: [openstack-dev] [nova] Retrospective veto revert policy

2014-08-12 Thread Daniel P. Berrange
On Tue, Aug 12, 2014 at 03:56:44PM +0100, Mark McLoughlin wrote: > Hey > > (Terrible name for a policy, I know) > > From the version_cap saga here: > > https://review.openstack.org/110754 > > I think we need a better understanding of how to approach situations > like this. > > Here's my atte

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-08-12 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 03:25:39PM -0700, Joe Gordon wrote: > I am not sure if I follow. The gate issue with live snapshots has been > worked around by turning it off [0], so presumably this patch is forward > facing. I fail to see how this patch is needed to help the gate in the > future. Wouldn

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 01:45:56PM +, Jeremy Stanley wrote: > On 2014-08-11 08:07:02 -0400 (-0400), Russell Bryant wrote: > > There's a pypi mirror at least. I'm not sure about mirroring > > other things. > > Right, that's a specific solution for mirroring the pypi.python.org > cheeseshop. We

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 07:58:41AM -0400, Russell Bryant wrote: > On 08/11/2014 05:53 AM, Daniel P. Berrange wrote: > > There is work to add support for this in devestack already which I > > prefer since it makes it easy for developers to get an environment > > which mat

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-08-11 Thread Daniel P. Berrange
On Fri, Aug 08, 2014 at 09:06:29AM -0400, Russell Bryant wrote: > On 08/07/2014 08:06 PM, Michael Still wrote: > > It seems to me that the tension here is that there are groups who > > would really like to use features in newer libvirts that we don't CI > > on in the gate. Is it naive to think that

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2014 at 08:57:31AM +1000, Michael Still wrote: > On Sun, Aug 10, 2014 at 2:33 AM, Jeremy Stanley wrote: > > On 2014-08-08 09:06:29 -0400 (-0400), Russell Bryant wrote: > > [...] > >> We've seen several times that building and maintaining 3rd party > >> CI is a *lot* of work. > > >

Re: [openstack-dev] [nova][libvirt] Non-readonly connection to libvirt in unit tests

2014-08-11 Thread Daniel P. Berrange
On Mon, Aug 04, 2014 at 06:46:13PM -0400, Solly Ross wrote: > Hi, > I was wondering if there was a way to get a non-readonly connection > to libvirt when running the unit tests > on the CI. If I call `LibvirtDriver._connect(LibvirtDriver.uri())`, > it works fine locally, but the upstream > CI barf

Re: [openstack-dev] [nova] so what do i do about libvirt-python if i'm on precise?

2014-07-30 Thread Daniel P. Berrange
On Wed, Jul 30, 2014 at 06:39:56AM -0700, Matt Riedemann wrote: > This change: > > https://review.openstack.org/#/c/105501/ > > Tries to pull in libvirt-python >= 1.2.5 for testing. > > I'm on Ubuntu Precise for development which has libvirt 0.9.8. > > The latest libvirt-python appears to requi

Re: [openstack-dev] [oslo.messaging][infra] Adding support for AMQP 1.0 Messaging to Oslo.Messaging and infra/config

2014-07-30 Thread Daniel P. Berrange
On Wed, Jul 30, 2014 at 08:54:01AM -0400, Ken Giusti wrote: > Greetings, > > Apologies for the cross-post: this should be of interest to both infra > and olso.messaging developers. > > The blueprint [0] that adds support for version 1.0 of the AMQP messaging > protocol is blocked due to CI test f

Re: [openstack-dev] [ALL] Removing the tox==1.6.1 pin

2014-07-30 Thread Daniel P. Berrange
On Fri, Jul 25, 2014 at 02:38:49PM -0700, Clark Boylan wrote: > New tox sets a random PYTHONHASHSEED value by default. Arguably this is > a good thing as it forces you to write code that handles unknown hash > seeds, but unfortunately many projects' unittests don't currently deal > with this very w

Re: [openstack-dev] [ALL] Removing the tox==1.6.1 pin

2014-07-30 Thread Daniel P. Berrange
On Fri, Jul 25, 2014 at 02:38:49PM -0700, Clark Boylan wrote: > Hello, > > The recent release of tox 1.7.2 has fixed the {posargs} interpolation > issues we had with newer tox which forced us to be pinned to tox==1.6.1. > Before we can remove the pin and start telling people to use latest tox > we

Re: [openstack-dev] [nova] stable branches & failure to handle review backlog

2014-07-30 Thread Daniel P. Berrange
On Wed, Jul 30, 2014 at 11:16:00AM +0200, Ihar Hrachyshka wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 29/07/14 18:12, Daniel P. Berrange wrote: > > On Tue, Jul 29, 2014 at 08:30:09AM -0700, Jay Pipes wrote: > >> On 07/29/2014 06:13 AM, Daniel P. B

Re: [openstack-dev] [nova] bug discussion at mid cycle meet up

2014-07-30 Thread Daniel P. Berrange
On Tue, Jul 29, 2014 at 02:48:12PM -0400, Russell Bryant wrote: > On 07/29/2014 11:43 AM, Tracy Jones wrote: > > 3. We have bugs that are really not bugs but features, or performance > > issues. They really should be a BP not a bug, but we don’t want these > > things to fall off the radar so they

Re: [openstack-dev] [nova] stable branches & failure to handle review backlog

2014-07-29 Thread Daniel P. Berrange
On Tue, Jul 29, 2014 at 08:30:09AM -0700, Jay Pipes wrote: > On 07/29/2014 06:13 AM, Daniel P. Berrange wrote: > >On Tue, Jul 29, 2014 at 02:04:42PM +0200, Thierry Carrez wrote: > >>Ihar Hrachyshka a écrit : > >>At the dawn of time there were no OpenStack stable branches

Re: [openstack-dev] [nova] stable branches & failure to handle review backlog

2014-07-29 Thread Daniel P. Berrange
On Tue, Jul 29, 2014 at 02:04:42PM +0200, Thierry Carrez wrote: > Ihar Hrachyshka a écrit : > At the dawn of time there were no OpenStack stable branches, each > distribution was maintaining its own stable branches, duplicating the > backporting work. At some point it was suggested (mostly by RedHa

[openstack-dev] [nova] stable branches & failure to handle review backlog

2014-07-29 Thread Daniel P. Berrange
Looking at the current review backlog I think that we have to seriously question whether our stable branch review process in Nova is working to an acceptable level On Havana - 43 patches pending - 19 patches with a single +2 - 1 patch with a -1 - 0 patches wit a -2 - Stalest waiting 111

Re: [openstack-dev] [Nova] Boot from ISO feature status

2014-07-29 Thread Daniel P. Berrange
On Mon, Jul 28, 2014 at 09:30:24AM -0700, Vishvananda Ishaya wrote: > I think we should discuss adding/changing this functionality. I have had > many new users assume that booting from an iso image would give them a > root drive which they could snapshot. I was hoping that the new block > device ma

Re: [openstack-dev] Thoughts on the patch test failure rate and moving forward

2014-07-28 Thread Daniel P. Berrange
On Mon, Jul 28, 2014 at 02:28:56PM +0200, Thierry Carrez wrote: > James E. Blair wrote: > > [...] > > Most of these bugs are not failures of the test system; they are real > > bugs. Many of them have even been in OpenStack for a long time, but are > > only becoming visible now due to improvements

Re: [openstack-dev] [infra] "recheck no bug" and comment

2014-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2014 at 07:35:52AM -0400, Sean Dague wrote: > On 07/25/2014 07:17 AM, Daniel P. Berrange wrote: > > On Fri, Jul 25, 2014 at 07:09:56AM -0400, Sean Dague wrote: > >> On 07/25/2014 06:53 AM, Daniel P. Berrange wrote: > >>> On Fri, Jul 25, 2014 at 06:3

Re: [openstack-dev] [infra] "recheck no bug" and comment

2014-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2014 at 07:09:56AM -0400, Sean Dague wrote: > On 07/25/2014 06:53 AM, Daniel P. Berrange wrote: > > On Fri, Jul 25, 2014 at 06:38:29AM -0400, Sean Dague wrote: > >> On 07/25/2014 01:18 AM, Ian Wienand wrote: > >>> On 07/16/2014 11:15 PM, Alexis Lee w

Re: [openstack-dev] [infra] "recheck no bug" and comment

2014-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2014 at 06:38:29AM -0400, Sean Dague wrote: > On 07/25/2014 01:18 AM, Ian Wienand wrote: > > On 07/16/2014 11:15 PM, Alexis Lee wrote: > >> What do you think about allowing some text after the words "recheck no > >> bug"? > > > > I think this is a good idea; I am often away from a

Re: [openstack-dev] Virtio-scsi settings nova-specs exception

2014-07-25 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 09:09:52AM +1000, Michael Still wrote: > Ok, I am going to take Daniel and Dan's comments as agreement that > this spec freeze exception should go ahead, so the exception is > approved. The exception is in the form of another week to get the spec > merged, so quick iteration

Re: [openstack-dev] vhost-scsi support in Nova

2014-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2014 at 01:18:33AM -0700, Nicholas A. Bellinger wrote: > On Thu, 2014-07-24 at 11:06 +0100, Daniel P. Berrange wrote: > > On Wed, Jul 23, 2014 at 10:32:44PM -0700, Nicholas A. Bellinger wrote: > > > *) vhost-scsi doesn't support migration > > > &

Re: [openstack-dev] Thoughts on the patch test failure rate and moving forward

2014-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2014 at 04:01:39PM -0400, Sean Dague wrote: > On 07/24/2014 12:40 PM, Daniel P. Berrange wrote: > > On Wed, Jul 23, 2014 at 02:39:47PM -0700, James E. Blair wrote: > > > >> ==Future changes== > > > >> ===Fixing Faster=== > >> >

Re: [openstack-dev] [gate] Automatic elastic rechecks

2014-07-24 Thread Daniel P. Berrange
On Thu, Jul 24, 2014 at 04:31:05PM +, Jeremy Stanley wrote: > On 2014-07-18 15:09:34 +0100 (+0100), Daniel P. Berrange wrote: > [...] > > If there were multiple failures and only some were identified, it would > > be reasonable to *not* automatically recheck. > [...] >

Re: [openstack-dev] Thoughts on the patch test failure rate and moving forward

2014-07-24 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 02:39:47PM -0700, James E. Blair wrote: > ==Future changes== > ===Fixing Faster=== > > We introduce bugs to OpenStack at some constant rate, which piles up > over time. Our systems currently treat all changes as equally risky and > important to the health of the system, w

Re: [openstack-dev] vhost-scsi support in Nova

2014-07-24 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 10:32:44PM -0700, Nicholas A. Bellinger wrote: > *) vhost-scsi doesn't support migration > > Since it's initial merge in QEMU v1.5, vhost-scsi has a migration blocker > set. This is primarily due to requiring some external orchestration in > order to setup the necessary vh

Re: [openstack-dev] [nova] Configuring libivrt VIF driver

2014-07-23 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 10:52:54AM -0700, Dan Smith wrote: > > If we're going to do that, then we should be consistent. eg there is > > a volume_drivers parameter that serves the same purpose as > > vif_driver > > There are lots of them. We've had a bit of a background task running to > remove the

Re: [openstack-dev] [Nova][Spec freeze exception] Controlled shutdown of GuestOS

2014-07-23 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 06:08:52PM +, Day, Phil wrote: > Hi Folks, > > I'd like to propose the following as an exception to the spec freeze, on the > basis that it addresses a potential data corruption issues in the Guest. > > https://review.openstack.org/#/c/89650 > > We were pretty close

Re: [openstack-dev] [nova] Configuring libivrt VIF driver

2014-07-23 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 10:09:37AM -0700, Dan Smith wrote: > > I don't see an issue with allowing people to configure 3rd party impl > > for the VIF driver, provided we don't claim that the VIF driver API > > contract is stable, same way we don't claim virt driver API is stable. > > It lets users h

Re: [openstack-dev] [nova] Configuring libivrt VIF driver

2014-07-23 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 09:53:55AM -0700, Dan Smith wrote: > > Hmm, that is not right. There's no intention to remove the vif_driver > > parameter itself. We were supposed to merely deprecate the various > > legacy VIF driver implementations in Nova, not remove the ability > > to use 3rd party ones

Re: [openstack-dev] [nova] threading in nova (greenthreads, OS threads, etc.)

2014-07-23 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 10:41:06AM -0600, Chris Friesen wrote: > > Hi all, > > I was wondering if someone could point me to a doc describing the threading > model for nova. > > I know that we use greenthreads to map multiple threads of execution onto a > single native OS thread. And the python

Re: [openstack-dev] [nova] Configuring libivrt VIF driver

2014-07-23 Thread Daniel P. Berrange
On Wed, Jul 23, 2014 at 07:38:05PM +0300, Itzik Brown wrote: > Hi, > > I see that the option to specify vif_driver in nova.conf for libvirt is > deprecated for Juno release. Hmm, that is not right. There's no intention to remove the vif_driver parameter itself. We were supposed to merely deprecat

Re: [openstack-dev] Virtio-scsi settings nova-specs exception

2014-07-21 Thread Daniel P. Berrange
On Mon, Jul 21, 2014 at 10:21:20AM +1000, Michael Still wrote: > I just want to check my understanding -- it seems to me that this > depends on a feature that's very new to libvirt (merged there 22 May > 2014). Is that right? > > http://libvirt.org/git/?p=libvirt.git;a=commit;h=d950494129513558a30

Re: [openstack-dev] [gate] Automatic elastic rechecks

2014-07-18 Thread Daniel P. Berrange
On Fri, Jul 18, 2014 at 09:06:45AM -0500, Matt Riedemann wrote: > > > On 7/17/2014 9:01 AM, Matthew Booth wrote: > >Elastic recheck is a great tool. It leaves me messages like this: > > > >=== > >I noticed jenkins failed, I think you hit bug(s): > > > >check-devstack-dsvm-cells: https://bugs.laun

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-18 Thread Daniel P. Berrange
On Thu, Jul 17, 2014 at 12:13:13PM -0700, Johannes Erdfelt wrote: > On Thu, Jul 17, 2014, Russell Bryant wrote: > > On 07/17/2014 02:31 PM, Johannes Erdfelt wrote: > > > It kind of helps. It's still implicit in that you need to look at what > > > features are enabled at what version and determine

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-17 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 09:44:55AM -0700, Johannes Erdfelt wrote: > On Wed, Jul 16, 2014, Mark McLoughlin wrote: > > No, there are features or code paths of the libvirt 1.2.5+ driver that > > aren't as well tested as the "class A" designation implies. And we have > > a proposal to make sure these

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2014 at 10:59:27AM +0200, Sean Dague wrote: > We've talked about the 'CI the world plan' for a while, which this would > be part of. That's a ton of work that no one is signed up for. > > But more importantly setting up and running the tests is < 10% of the > time cost. Triage and

Re: [openstack-dev] [specs] how to continue spec discussion

2014-07-17 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 03:30:56PM +0100, John Garbutt wrote: > My intention was that once the specific project is open for K specs, > people will restore their original patch set, and move the spec to the > K directory, thus keeping all the history. > > For Nova, the open reviews, with a -2, are

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-17 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 12:38:44PM -0600, Chris Friesen wrote: > On 07/16/2014 11:59 AM, Monty Taylor wrote: > >On 07/16/2014 07:27 PM, Vishvananda Ishaya wrote: > > >>This is a really good point. As someone who has to deal with packaging > >>issues constantly, it is odd to me that libvirt is one

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-17 Thread Daniel P. Berrange
On Thu, Jul 17, 2014 at 08:46:12AM +1000, Michael Still wrote: > Top posting to the original email because I want this to stand out... > > I've added this to the agenda for the nova mid cycle meetup, I think > most of the contributors to this thread will be there. So, if we can > nail this down he

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-16 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 08:29:26AM -0700, Dan Smith wrote: > >> Based on these experiences, libvirt version differences seem to be as > >> substantial as major hypervisor differences. > > > > I think that is a pretty dubious conclusion to draw from just a > > couple of bugs. The reason they really

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-16 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 08:12:47AM -0700, Clark Boylan wrote: > On Wed, Jul 16, 2014 at 7:50 AM, Daniel P. Berrange > wrote: > > On Wed, Jul 16, 2014 at 04:15:40PM +0200, Sean Dague wrote: > >> Recently the main gate updated from Ubuntu 12.04 to 14.04, and in doing > &g

Re: [openstack-dev] [nova] fair standards for all hypervisor drivers

2014-07-16 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 04:15:40PM +0200, Sean Dague wrote: > Recently the main gate updated from Ubuntu 12.04 to 14.04, and in doing > so we started executing the livesnapshot code in the nova libvirt > driver. Which fails about 20% of the time in the gate, as we're bringing > computes up and down

Re: [openstack-dev] [specs] how to continue spec discussion

2014-07-16 Thread Daniel P. Berrange
On Wed, Jul 16, 2014 at 11:57:33AM +, Tim Bell wrote: > As we approach Juno-3, a number of specs have been correctly marked > as abandoned since they are not expected to be ready in time for the > release. > > Is there a mechanism to keep these specs open for discussion even > though there is

Re: [openstack-dev] [nova][all] Old review expiration

2014-07-14 Thread Daniel P. Berrange
On Mon, Jul 14, 2014 at 11:01:17AM -0500, Kevin L. Mitchell wrote: > On Sat, 2014-07-12 at 12:46 -0400, Jay Pipes wrote: > > > Given that we have so many old reviews hanging around on nova (and > > > probably other projects), should we consider setting something like that > > > back up? With nova,

Re: [openstack-dev] [nova][vmware] Convert to rescue by adding the rescue image and booting from it

2014-07-14 Thread Daniel P. Berrange
On Mon, Jul 14, 2014 at 10:48:17AM +0100, Matthew Booth wrote: > > That's interesting. I didn't realise that other drivers had the same > limitations. Does anybody understand the original thinking which lead to > this design? The single VM approach seems intuitively correct to me, so > presumably

Re: [openstack-dev] Python 2.6 being dropped in K? What does that entail?

2014-07-11 Thread Daniel P. Berrange
On Fri, Jul 11, 2014 at 08:45:07AM -0500, Matt Riedemann wrote: > I'm hearing that python 2.6 will no longer be support in the K release but > not sure if there is an official statement about that somewhere (wiki?). > > I realize this means turning off the 2.6 unit test jobs, but what other > runt

Re: [openstack-dev] [Containers] Nova virt driver requirements

2014-07-11 Thread Daniel P. Berrange
On Fri, Jul 11, 2014 at 09:53:47AM -0400, Eric Windisch wrote: > > > > > > > Actually, there's a hidden assumption here that makes this statement not > > > necessarily correct for containers. You're assuming the container has > > > to have raw access to the device it's mounting. For hypervisors,

Re: [openstack-dev] [nova][vmware] Convert to rescue by adding the rescue image and booting from it

2014-07-11 Thread Daniel P. Berrange
On Fri, Jul 11, 2014 at 12:30:19PM +0100, John Garbutt wrote: > On 10 July 2014 16:52, Matthew Booth wrote: > > Currently we create a rescue instance by creating a new VM with the > > original instance's image, then adding the original instance's first > > disk to it, and booting. This means we ha

Re: [openstack-dev] [Containers] Nova virt driver requirements

2014-07-10 Thread Daniel P. Berrange
On Thu, Jul 10, 2014 at 08:19:36AM -0700, James Bottomley wrote: > On Thu, 2014-07-10 at 14:47 +0100, Daniel P. Berrange wrote: > > On Thu, Jul 10, 2014 at 05:36:59PM +0400, Dmitry Guryanov wrote: > > > I have a question about mounts - in OpenVZ project each container

Re: [openstack-dev] [Containers] Nova virt driver requirements

2014-07-10 Thread Daniel P. Berrange
On Thu, Jul 10, 2014 at 06:18:52PM +0400, Dmitry Guryanov wrote: > On Thursday 10 July 2014 14:47:11 Daniel P. Berrange wrote: > > On Thu, Jul 10, 2014 at 05:36:59PM +0400, Dmitry Guryanov wrote: > > > I have a question about mounts - in OpenVZ project each container has its &g

Re: [openstack-dev] [Containers] Nova virt driver requirements

2014-07-10 Thread Daniel P. Berrange
On Thu, Jul 10, 2014 at 05:57:46PM +0400, Dmitry Guryanov wrote: > On Tuesday 08 July 2014 14:10:25 Michael Still wrote: > > Joe has a good answer, but you should also be aware of the hypervisor > > support matrix (https://wiki.openstack.org/wiki/HypervisorSupportMatrix), > > which hopefully comes

Re: [openstack-dev] [Containers] Nova virt driver requirements

2014-07-10 Thread Daniel P. Berrange
On Thu, Jul 10, 2014 at 05:36:59PM +0400, Dmitry Guryanov wrote: > I have a question about mounts - in OpenVZ project each container has its own > filesystem in an image file. So to start a container we mount this filesystem > in host OS (because all containers share the same linux kernel). Is it

Re: [openstack-dev] [nova] top gate bug is libvirt snapshot

2014-07-10 Thread Daniel P. Berrange
On Thu, Jul 10, 2014 at 08:32:37AM -0400, Sean Dague wrote: > On 07/10/2014 05:03 AM, Daniel P. Berrange wrote: > > On Wed, Jul 09, 2014 at 06:23:27PM -0400, Sean Dague wrote: > >> The libvirt logs needed are huge, so we can't run them all the time. And > >> r

Re: [openstack-dev] [nova] top gate bug is libvirt snapshot

2014-07-10 Thread Daniel P. Berrange
On Wed, Jul 09, 2014 at 06:23:27PM -0400, Sean Dague wrote: > The libvirt logs needed are huge, so we can't run them all the time. And > realistically, I don't think they provided us the info we needed. There > has been at least one fail on Dan's log hack patch for this scenario > today, so maybe i

Re: [openstack-dev] [nova] top gate bug is libvirt snapshot

2014-07-09 Thread Daniel P. Berrange
On Wed, Jul 09, 2014 at 08:34:06AM -0400, Sean Dague wrote: > On 07/09/2014 03:58 AM, Daniel P. Berrange wrote: > > On Tue, Jul 08, 2014 at 02:50:40PM -0700, Joe Gordon wrote: > >>>> But for right now, we should stop the bleeding, so that nova/libvirt > >>>

Re: [openstack-dev] [olso] olso incubator logging issues

2014-07-09 Thread Daniel P. Berrange
On Wed, Jul 09, 2014 at 07:39:39AM -0400, Sean Dague wrote: > On 07/03/2014 01:52 PM, Doug Hellmann wrote: > >> oslo code, by definition, is going to be used a lot, inside of tight > >> loops. Which means extremely verbose. Actually > >> nova.openstack.common.policy currently represents ~40% of all

Re: [openstack-dev] [olso] olso incubator logging issues

2014-07-09 Thread Daniel P. Berrange
ah, I saw that last week and already sent a fix to oslo for that which is merged, so projects need to re-sync to oslo, or cherry pick this: commit 33afb20cc0e6790ae82e1bfe211d47f34c22ff91 Author: Daniel P. Berrange Date: Mon Jun 30 16:25:01 2014 +0100 Fix broken formatting of process

Re: [openstack-dev] [nova] top gate bug is libvirt snapshot

2014-07-09 Thread Daniel P. Berrange
On Wed, Jul 09, 2014 at 08:58:02AM +1000, Michael Still wrote: > On Wed, Jul 9, 2014 at 8:21 AM, Sean Dague wrote: > > > This is also why I find it unlikely to be a qemu bug, because that's not > > shared state between guests. If qemu just randomly wedges itself, that > > would be detectable much

Re: [openstack-dev] [nova] top gate bug is libvirt snapshot

2014-07-09 Thread Daniel P. Berrange
On Tue, Jul 08, 2014 at 02:50:40PM -0700, Joe Gordon wrote: > > > But for right now, we should stop the bleeding, so that nova/libvirt > > > isn't blocking everyone else from merging code. > > > > Agreed, we should merge the hack and treat the bug as release blocker > > to be resolve prior to Juno

Re: [openstack-dev] [nova][libvirt] Suspend via virDomainSave() rather than virDomainManagedSave()

2014-07-07 Thread Daniel P. Berrange
On Sun, Jul 06, 2014 at 10:22:44PM -0700, Rafi Khardalian wrote: > Hi All -- > > It seems as though it would be beneficial to use virDomainSave rather than > virDomainManagedSave for suspending instances. The primary benefit of > doing so would be to locate the save files within the instance's de

<    1   2   3   4   5   6   7   8   9   >