Re: [openstack-dev] [Fuel][Fuel-QA][Fuel-TechDebt] Code Quality: Do Not Hardcode - Fix Things Instead

2015-11-11 Thread Igor Kalnitsky
Folks, I have one thing to add: if workaround is unavoidable, please DO comment it. Usually workaround aren't obvious, and it would be incredibly helpful to comment all of them; and do not hesitate to write extensive comments. The clearer you write - the less time your colleagues will spend next

Re: [openstack-dev] [Fuel][Fuel-QA][Fuel-TechDebt] Code Quality: Do Not Hardcode - Fix Things Instead

2015-11-11 Thread Vladimir Kuklin
Matthew Thanks for your feedback. Could you please elaborate more on the statistics of such tech-debt eliminations? My perception is that such bugs do not ever get fixed actually jeopardizing our efforts on bugfixing and actually making our statistics manupilative. So far my suggestion is the fol

Re: [openstack-dev] [Fuel][Fuel-QA][Fuel-TechDebt] Code Quality: Do Not Hardcode - Fix Things Instead

2015-11-11 Thread Matthew Mosesohn
Vladimir, Bugfixes and minor refactoring often belong in separate commits. Combining "extending foo to enable bar in XYZ" with "ensuring logs from service abc are sent via syslog" often makes little sense to code reviewers. In this case it is a feature enhancement + a bugfix. Looking at it from o

Re: [openstack-dev] [Fuel][Fuel-QA][Fuel-TechDebt] Code Quality: Do Not Hardcode - Fix Things Instead

2015-11-10 Thread Aleksandr Didenko
+1 from me On Tue, Nov 10, 2015 at 6:38 PM, Stanislaw Bogatkin wrote: > I think that it is excellent thought. > +1 > > On Tue, Nov 10, 2015 at 6:52 PM, Vladimir Kuklin > wrote: > >> Folks >> >> I wanted to raise awareness about one of the things I captured while >> doing reviews recently - we a

Re: [openstack-dev] [Fuel][Fuel-QA][Fuel-TechDebt] Code Quality: Do Not Hardcode - Fix Things Instead

2015-11-10 Thread Stanislaw Bogatkin
I think that it is excellent thought. +1 On Tue, Nov 10, 2015 at 6:52 PM, Vladimir Kuklin wrote: > Folks > > I wanted to raise awareness about one of the things I captured while doing > reviews recently - we are sacrificing quality to bugfixing and feature > development velocity, essentially mov

[openstack-dev] [Fuel][Fuel-QA][Fuel-TechDebt] Code Quality: Do Not Hardcode - Fix Things Instead

2015-11-10 Thread Vladimir Kuklin
Folks I wanted to raise awareness about one of the things I captured while doing reviews recently - we are sacrificing quality to bugfixing and feature development velocity, essentially moving from one heap to another - from bugs/features to 'tech-debt' bugs. I understand that we all have deadlin