Re: [openstack-dev] [Fuel][Nailgun] Random failures in unit tests

2016-03-23 Thread Mike Scherbakov
I finally got it passing all the tests, including performance: https://review.openstack.org/#/c/294976/. I'd appreciate if you guys can review/land it sooner than later: patch touches many tests, and it would be beneficial for everyone to be based on updated code. Thanks, On Mon, Mar 21, 2016 at

Re: [openstack-dev] [Fuel][Nailgun] Random failures in unit tests

2016-03-21 Thread Mike Scherbakov
FakeUI, which is based on fake threads, is obviously needed for development purposes. Ideally we need to refactor our integration tests, so that we don't run whole pipeline in every test. To start, I suggest that we switch from threads to synchronous runs of test cases (while keeping threads for fa

[openstack-dev] [Fuel][Nailgun] Random failures in unit tests

2016-03-19 Thread Igor Kalnitsky
Hey Fuelers, As you might know recently we encounter a lot of random test failures on CI, and they are still there (likely with a bit less probability). A nature of that random failures is actually not a random, they are happened because of so called fake threads. Fake threads, actually, ain't fa

Re: [openstack-dev] [Fuel][Nailgun] Random failures in unit tests

2016-03-19 Thread Igor Kalnitsky
Hey Vitaly, Thanks for your feedback, it's an important notice. However, I think you didn't get the problem quite well so let me explain it again. You see, Nailgun unit tests are failing due to races or deadlocks happened by two transactions: test transaction and fake thread transaction, and we m

Re: [openstack-dev] [Fuel][Nailgun] Random failures in unit tests

2016-03-18 Thread Vitaly Kramskikh
Igor, We have UI and CLI integration tests which use fake mode of Nailgun, and we can't avoid using fake threads for them. So I think we need to think how to fix fake threads instead. There is a critical bug which is the main reason of randomly failin