Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-13 Thread Gorka Eguileor
On Thu, Mar 12, 2015 at 10:58:37AM -0700, Jim Rollenhagen wrote: On Thu, Mar 12, 2015 at 09:07:30AM -0500, Flavio Percoco wrote: On 11/03/15 15:06 -1000, John Bresnahan wrote: FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-13 Thread Flavio Percoco
On 13/03/15 10:36 +0100, Gorka Eguileor wrote: On Thu, Mar 12, 2015 at 10:58:37AM -0700, Jim Rollenhagen wrote: On Thu, Mar 12, 2015 at 09:07:30AM -0500, Flavio Percoco wrote: On 11/03/15 15:06 -1000, John Bresnahan wrote: FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-12 Thread Daniel P. Berrange
On Thu, Mar 12, 2015 at 09:07:30AM -0500, Flavio Percoco wrote: On 11/03/15 15:06 -1000, John Bresnahan wrote: FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the quality standard to which the product is held even in commit messages

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-12 Thread Flavio Percoco
On 11/03/15 15:06 -1000, John Bresnahan wrote: FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the quality standard to which the product is held even in commit messages and comments (consider the 'broken window theory'). Of course

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-12 Thread Jim Rollenhagen
On Thu, Mar 12, 2015 at 09:07:30AM -0500, Flavio Percoco wrote: On 11/03/15 15:06 -1000, John Bresnahan wrote: FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the quality standard to which the product is held even in commit messages

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-12 Thread Ian Cordasco
On 3/12/15, 09:26, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Mar 12, 2015 at 09:07:30AM -0500, Flavio Percoco wrote: On 11/03/15 15:06 -1000, John Bresnahan wrote: FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-12 Thread Nikhil Komawar
+2A :P (Daniel and Ian) Thanks, -Nikhil From: Ian Cordasco ian.corda...@rackspace.com Sent: Thursday, March 12, 2015 10:59 AM To: Daniel P. Berrange; OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [Glance

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-11 Thread John Bresnahan
FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the quality standard to which the product is held even in commit messages and comments (consider the 'broken window theory'). Of course everyone makes mistakes (I am a terrible speller)

[openstack-dev] [Glance] Nitpicking in code reviews

2015-03-11 Thread Kuvaja, Erno
Hi all, Following the code reviews lately I've noticed that we (the fan club seems to be growing on weekly basis) have been growing culture of nitpicking [1] and bikeshedding [2][3] over almost every single change. Seriously my dear friends, following things are not worth of -1 vote if even a

Re: [openstack-dev] [Glance] Nitpicking in code reviews

2015-03-11 Thread Nikhil Komawar
@lists.openstack.org Subject: Re: [openstack-dev] [Glance] Nitpicking in code reviews FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy enough thing to get right and speaks to the quality standard to which the product is held even in commit messages and comments (consider the 'broken