Re: [openstack-dev] [Ironic] *ED states strike back

2015-02-20 Thread John Villalovos
Ruby, What you say makes sense to me. On keeping things consistent. So sounds good to me to always use them and not have them be optional. John On Thu, Feb 19, 2015 at 9:32 AM, Ruby Loo rlooya...@gmail.com wrote: I think that if there is a use case for an *ED state, then we should have it.

[openstack-dev] [Ironic] *ED states strike back

2015-02-19 Thread Dmitry Tantsur
Hi everyone! On one of our meetings [1] we agreed on keeping *ED states (DELETED, INSPECTED, CLEANED, etc) as no-ops for now. Since then, however, the inspection patch [2] got several comments from cores requesting removal of INSPECTED state. That was done by Nisha. Today we decided to

Re: [openstack-dev] [Ironic] *ED states strike back

2015-02-19 Thread John Villalovos
Can the *ED states be optional? If a state would be a NO-OP, then don't use it. But if it is useful then use it. It seems ugly to me to just have two 'change state' calls to move it through the *ED state. If an *ED state needs to be added later I think it could be added without too much

Re: [openstack-dev] [Ironic] *ED states strike back

2015-02-19 Thread Ruby Loo
I think that if there is a use case for an *ED state, then we should have it. And if we have one *ED state, I think it makes sense (and is consistent) to have them for all the active states. If we have *ED states, I would prefer that we add them in when the active state is added. So add stateING,