Re: [openstack-dev] [Neutron][networking-*] Attention for upcoming refactoring

2017-01-04 Thread Kevin Benton
If you wanted one compatible with both you could have a line like this. session = ctx.session if isinstance(ctx, neutron.context.Context) else ctx On Tue, Jan 3, 2017 at 2:52 PM, Ian Wells wrote: > I see this changes a function's argument types without changing the > function's name - for insta

Re: [openstack-dev] [Neutron][networking-*] Attention for upcoming refactoring

2017-01-03 Thread Ian Wells
I see this changes a function's argument types without changing the function's name - for instance, in the proposed networking-cisco change, https://review.openstack.org/#/c/409045/ . This makes it hard to detect that there's been a change and react accordingly. What's the recommended way to writ

Re: [openstack-dev] [Neutron][networking-*] Attention for upcoming refactoring

2016-12-27 Thread Anna Taraday
Hello everyone! Please, note that all changes to Neutron merged. Changes that needs to be merged for external repos: segments db refactor - https://review.openstack.org/#/q/status:open+branch:master+topic:segmentsdb ml2 db refactor - https://review.openstack.org/#/q/status:open+branch:master+topi

Re: [openstack-dev] [Neutron][networking-*] Attention for upcoming refactoring

2016-12-21 Thread Russell Bryant
On Wed, Dec 21, 2016 at 10:50 AM, Anna Taraday wrote: > Hello everyone! > > I've got two changes with refactor of TypeDriver [1] and segments db [2] > which is needed for implementation new engine facade [3]. > > Reviewers of networking-cisco, networking-arista, networking-nec >

[openstack-dev] [Neutron][networking-*] Attention for upcoming refactoring

2016-12-21 Thread Anna Taraday
Hello everyone! I've got two changes with refactor of TypeDriver [1] and segments db [2] which is needed for implementation new engine facade [3]. Reviewers of networking-cisco, networking-arista, networking-nec