Re: [openstack-dev] [Nova][db] Changing migrations

2013-11-18 Thread Mark McLoughlin
On Mon, 2013-11-18 at 18:46 +0100, Nikola Đipanov wrote: > Dear OpenStack devs, > > A recent review [1] dragged into spotlight how damaging improper use of > external code inside migrations can be. > > Basically in my mind the incident raises 2 issues that I think we should > look into: > > 1) H

Re: [openstack-dev] [Nova][db] Changing migrations

2013-11-18 Thread Nikola Đipanov
On 18/11/13 18:46, Nikola Đipanov wrote: > 1) How can we make reviewing changes with db migrations more robust > > Since we use sqlalchemy-migrate to version our database, the package's > documentation [2] states how care needs to be taken when importing code > inside a db migration script. It see

[openstack-dev] [Nova][db] Changing migrations

2013-11-18 Thread Nikola Đipanov
Dear OpenStack devs, A recent review [1] dragged into spotlight how damaging improper use of external code inside migrations can be. Basically in my mind the incident raises 2 issues that I think we should look into: 1) How can we make reviewing changes with db migrations more robust Since we u