Hi,
here is the commit on review:
https://review.openstack.org/#/c/200433
We already added non-voting job in infra repository, need to merge this
script.
On Fri, Jul 3, 2015 at 1:29 PM, Anastasia Kuznetsova
akuznets...@mirantis.com wrote:
Boris,
thanks for an explanation! I will take a
Boris,
thanks for an explanation! I will take a closer look at the cover.sh script.
On Fri, Jul 3, 2015 at 12:07 AM, Boris Pavlovic bpavlo...@mirantis.com
wrote:
Anastasia,
because new patch may not be just a new code, committer may delete
something or fix typos in docsting, etc.
This
Hi Timur,
Generally I think that it is a good idea to have a gate that will check
whether new code is covered by unit tests or not. But I am not sure that
this gate should be voting (if I understand you correct),
because new patch may not be just a new code, committer may delete
something or fix
Hi all,
I suggest to add CI job which will check the unit tests coverage for Sahara
repository and will set -1 for commits with new code and without unit tests
(if we have some degradation of tests coverage).
This job successfully works for Rally project and it helps to organize the
right code
Hi all,
I suggest to add CI job which will check the unit tests coverage for Sahara
repository and will set -1 for commits with new code and without unit tests
(if we have some degradation of tests coverage).
This job successfully works for Rally project and it helps to organize the
right code
Hi Timur,
I absolutely disagree with this approach. IMO such checks just helps to
organize the unhealthy dev process when contributors will write tests only
to pass this check. We have a non-voting coverage job to track the unit
tests coverage in addition to the code review itself. It's the
Anastasia,
because new patch may not be just a new code, committer may delete
something or fix typos in docsting, etc.
This job compares amount of non covered lines (before and after patch).
If you just remove code there will be less lines that should be covered so
amount of non covered lines
Hi Sergey,
Looks like I suggested job which we already have :) so, I think non-voiting
coverage job is ok for Sahara project and we can just continue to use it.
Thank you!
On Thu, Jul 2, 2015 at 11:06 PM, Sergey Lukjanov slukja...@mirantis.com
wrote:
Hi Timur,
I absolutely disagree with
