Re: [openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Adrian Otto
On Nov 1, 2013, at 7:03 PM, Noorul Islam K M mailto:noo...@noorul.com>> wrote: Clark Boylan mailto:clark.boy...@gmail.com>> writes: On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M mailto:noo...@noorul.com>> wrote: Now we have the first patch [1] merged into the repository using OpenStack r

Re: [openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Noorul Islam K M
Clark Boylan writes: > On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M wrote: > >> >> Now we have the first patch [1] merged into the repository using >> OpenStack review process. I would like to bring into notice some minor >> issues. >> >> First of all I would like to thank [2] Swapnil for fi

Re: [openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Clark Boylan
On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M wrote: > > Now we have the first patch [1] merged into the repository using > OpenStack review process. I would like to bring into notice some minor > issues. > > First of all I would like to thank [2] Swapnil for fixing the patch. > > 1. Look at pa

[openstack-dev] [Solum] Dissecting the very first review

2013-11-01 Thread Noorul Islam K M
Now we have the first patch [1] merged into the repository using OpenStack review process. I would like to bring into notice some minor issues. First of all I would like to thank [2] Swapnil for fixing the patch. 1. Look at patch set 3 and it changed the Author and also the Committer. I am no