Re: [openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-21 Thread Petr Kovar
On Sun, 18 Feb 2018 15:44:04 -0500 Doug Hellmann wrote: > Excerpts from Jeremy Stanley's message of 2018-02-18 16:01:52 +: > > On 2018-02-18 03:55:51 -0600 (-0600), Monty Taylor wrote: > > [...] > > > I'd honestly argue in favor of assuming bash and using 'source' > >

Re: [openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-20 Thread Dean Troyer
>> On 2018-02-18 03:55:51 -0600 (-0600), Monty Taylor wrote: >> > That said - I completely agree with fungi on the description of >> > the tradeoffs of each direction, and I do think it's valuable to >> > pick one for the docs. FWIW, DevStack declared long ago that it was built to use bash, even

Re: [openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-18 Thread Doug Hellmann
Excerpts from Jeremy Stanley's message of 2018-02-18 16:01:52 +: > On 2018-02-18 03:55:51 -0600 (-0600), Monty Taylor wrote: > [...] > > I'd honestly argue in favor of assuming bash and using 'source' > > because it's more readable. We don't make allowances for alternate > > shells in our

Re: [openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-18 Thread Jeremy Stanley
On 2018-02-18 03:55:51 -0600 (-0600), Monty Taylor wrote: [...] > I'd honestly argue in favor of assuming bash and using 'source' > because it's more readable. We don't make allowances for alternate > shells in our examples anyway. > > I personally try to use 'source' vs . and $() vs. `` as >

Re: [openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-18 Thread Monty Taylor
On 02/17/2018 03:03 PM, Jeremy Stanley wrote: On 2018-02-17 13:47:02 -0500 (-0500), Hongbin Lu wrote: [...] If anyone can clarify the rationals of this convention, it will be really helpful. [...] There's a trade-off here: while `.` is standardized in POSIX sh (under Utilities, Dot in the

Re: [openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-17 Thread Jeremy Stanley
On 2018-02-17 13:47:02 -0500 (-0500), Hongbin Lu wrote: [...] > If anyone can clarify the rationals of this convention, it will be > really helpful. [...] There's a trade-off here: while `.` is standardized in POSIX sh (under Utilities, Dot in the specification), it's easy to miss when reading

[openstack-dev] [docs] About the convention to use '.' instead of 'source'.

2018-02-17 Thread Hongbin Lu
Hi all, We have contributors submit patches [1] about switching over from 'source' to '.'. Frankly, it is a bit confused for reviewers to review those patches since it is unclear what are the rationals of the change. By tracing down to the patch [2] that introduced this convention,