Re: [openstack-dev] [horizon][xstatic]How to handle xstatic if upstream files are modified

2018-04-10 Thread Xinni Ge
Hi Radomir, Ivan, Thanks a lot for your advice. I will update the xstatic files just as the upstream. As for the customized lines, I will try to find a better way to solve it, maybe override the original functions inside the project. Best regards, Xinni On Tue, Apr 10, 2018 at 4:58 AM, Ivan

Re: [openstack-dev] [horizon][xstatic]How to handle xstatic if upstream files are modified

2018-04-09 Thread Ivan Kolodyazhny
Hi, Xinni, I absolutely agree with Radomir. We should keep xstatic files without modifications. We don't know if they are used outside of OpenStack or not, so they should be the same as NPM packages Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Mon, Apr 9, 2018 at 12:32 PM, Radomir

Re: [openstack-dev] [horizon][xstatic]How to handle xstatic if upstream files are modified

2018-04-09 Thread Radomir Dopieralski
The whole idea about xstatic files is that they are generic, not specific to Horizon or OpenStack, usable by other projects that need those static files. In fact, at the time we started using xstatic, it was being used by the MoinMoin wiki project (which is now dead, sadly). The modifications you

[openstack-dev] [horizon][xstatic]How to handle xstatic if upstream files are modified

2018-04-08 Thread Xinni Ge
Hello, team. Sorry for talking about xstatic repo for so many times. I didn't realize xstatic repositories should be provided with exactly the same file as upstream, and should have talked about it at very first. I modified several upstream files because some of them files couldn't be used