On 8/26/15 4:47 AM, Grasza, Grzegorz wrote:
Hi,
I noticed that right now, when we make changes (adding/removing
fields) in
https://github.com/openstack/magnum/tree/master/magnum/objects , we
don't change object versions.
The idea of objects is that each change in their fields should be
st (not for usage questions)"
mailto:openstack-dev@lists.openstack.org>>
Date: Friday, August 28, 2015 at 18:51
To: "OpenStack Development Mailing List (not for usage questions)"
mailto:openstack-dev@lists.openstack.org>>
Subject: Re: [openstack-dev] [magnum] versioned
We are going to merge this work. I understand and respect Hongbin's position,
but I respectfully disagree. When we are presented with ways to implement low
overhead best practices like versioned objects, we will. It's not that hard to
bump the version of an object when you change it. I like havi
Hongbin,
We are hearing the best advice available from the folks who started the
library, evangelized it across nova, ironic, heat, neutron etc.
If we can spend so much time and energy (*FOUR* -1's on a review which just
changes some commented lines - https://review.openstack.org/#/c/211057/)
the
> If you want my inexperienced opinion, a young project is the perfect
> time to start this.
^--- This ---^
> I understand that something like [2] will cause a test to fail when you
> make a major change to a versioned object. But you *want* that. It helps
> reviewers more easily catch co
.com]
Sent: August-27-15 2:41 PM
To: openstack-dev@lists.openstack.org
Subject: Re: [openstack-dev] [magnum] versioned objects changes
If you want my inexperienced opinion, a young project is the perfect time to
start this. Nova has had a bunch of problems with versioned objects that don'
ust-26-15 4:47 AM
*To:* OpenStack Development Mailing List (not for usage questions)
*Subject:* [openstack-dev] [magnum] versioned objects changes
Hi,
I noticed that right now, when we make changes (adding/removing
fields) in
https://github.com/openstack/magnum/tree/master/magnum/objects , we
d
ree to enforce the rule of object version change in the near future.
Best regards,
Hongbin
From: Grasza, Grzegorz [mailto:grzegorz.gra...@intel.com]
Sent: August-26-15 4:47 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: [openstack-dev] [magnum] versioned objects c
I've been working with Nova's versioned objects lately to help catch
people when object changes are made. There is a lot of object-related
tests in Nova for this, and a major one I can see helping this situation
is this test [1]. Looking through the different versioned objects within
Magnum, I
Hi,
I noticed that right now, when we make changes (adding/removing fields) in
https://github.com/openstack/magnum/tree/master/magnum/objects , we don't
change object versions.
The idea of objects is that each change in their fields should be versioned,
documentation about the change should al
10 matches
Mail list logo
