Re: [openstack-dev] [neutron] Need community weigh-in on requests-mock

2014-08-22 Thread Carl Baldwin
I put this in the review but will repeat it here. +1 to adding the dependency with the tests that you've written to require it when those tests have been reviewed and accepted. I don't have an objection to adding requests-mock as a test-requirement. Carl On Fri, Aug 22, 2014 at 12:50 PM, Paul M

[openstack-dev] [neutron] Need community weigh-in on requests-mock

2014-08-22 Thread Paul Michali (pcm)
Hi! Need to get the community to weigh in on this… In Neutron there currently is no mock library for the Requests package. During Icehouse, I created unit tests that used the httmock package (a context-library based Requests mock). However, the community did not want me to add this to global re