Re: [openstack-dev] [nova] [ironic] Input types for scheduler filters

2016-07-11 Thread Miles Gould
On 08/07/16 15:22, Miles Gould wrote: On 07/07/16 17:43, Miles Gould wrote: Further evidence that this isn't the intended behaviour: if you remove all the calls to str(), then the original tests still pass, but the ' e' (substring matching) one doesn't. I've now proposed this as a patch:

Re: [openstack-dev] [nova] [ironic] Input types for scheduler filters

2016-07-08 Thread Miles Gould
On 07/07/16 17:43, Miles Gould wrote: Further evidence that this isn't the intended behaviour: if you remove all the calls to str(), then the original tests still pass, but the ' e' (substring matching) one doesn't. I've now proposed this as a patch: https://review.openstack.org/#/c/339576/

[openstack-dev] [nova] [ironic] Input types for scheduler filters

2016-07-07 Thread Miles Gould
Hi everyone, tl;dr: the tests for the operator in nova.scheduler.filters.extra_specs_ops do not test what it looks like they're meant to test. This is confusing us, and holding up work in Ironic. Does it match its arguments against a list of strings, or against a single string?