Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-10 Thread Lenny Verkhovsky
usage questions) Subject: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code Just a heads up that this recently merged code is wrong: https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm and here it is failing tests on my local env, as it

Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Davanum Srinivas
Mike, Sounds great! +1 to fix the code. -- dims On Fri, Aug 7, 2015 at 9:55 PM, Mike Bayer wrote: > > > On 8/7/15 8:00 PM, Davanum Srinivas wrote: > > Mike, > > I edited my nova tox.ini like so: > http://paste.openstack.org/show/412245/ > > and it seems to be working for me: > http://paste.ope

Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Mike Bayer
On 8/7/15 8:00 PM, Davanum Srinivas wrote: Mike, I edited my nova tox.ini like so: http://paste.openstack.org/show/412245/ and it seems to be working for me: http://paste.openstack.org/show/412246/ OK I can see why the gate passes, the error is exposed only by Alembic 0.8, because the Column

Re: [openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Davanum Srinivas
Mike, I edited my nova tox.ini like so: http://paste.openstack.org/show/412245/ and it seems to be working for me: http://paste.openstack.org/show/412246/ -- dims On Fri, Aug 7, 2015 at 6:42 PM, Mike Bayer wrote: > Just a heads up that this recently merged code is wrong: > > > https://review.

[openstack-dev] [nova] [oslo] troubling passing of unit tests on broken code

2015-08-07 Thread Mike Bayer
Just a heads up that this recently merged code is wrong: https://review.openstack.org/#/c/192760/14/nova/tests/unit/db/test_migrations.py,cm and here it is failing tests on my local env, as it does on my CI, as would be expected, there's a lot more if I keep it running: http://paste.openstack