Re: [openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

2018-05-16 Thread Matt Riedemann
On 8/31/2017 2:14 PM, Matt Riedemann wrote: The change to deprecate the monkey_patch and monkey_patch_modules option was deprecated in Queens, so they wouldn't be removed until the Rocky release at the earliest. We don't backport changes which deprecate things. My recommendation to you is

Re: [openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

2017-08-31 Thread Matt Riedemann
On 8/30/2017 1:16 PM, Lokesh Jain wrote: Hi Matt, Thank you for pointing this out and bringing this to my attention. We are using the monkey_patch options to add more nova capabilities. Specifically we are using it to replace Nova’s nova/network/neutronv2/api.get_port_vnic_info function for

[openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

2017-08-30 Thread Lokesh Jain
Hi Matt, Thank you for pointing this out and bringing this to my attention. We are using the monkey_patch options to add more nova capabilities. Specifically we are using it to replace Nova’s nova/network/neutronv2/api.get_port_vnic_info function for extending the vnic type + phys network

Re: [openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

2017-08-28 Thread Matt Riedemann
On 8/28/2017 9:51 AM, Alex Schultz wrote: JFYI,https://review.openstack.org/#/c/494305/ Since this was just added, someone is looking to use it or is using it. Thanks for pointing this out. I've asked in the puppet review that the submitter of that change explain if/why they are using this

Re: [openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

2017-08-28 Thread Alex Schultz
On Fri, Aug 25, 2017 at 3:51 PM, Matt Riedemann wrote: > I'm having a hard time tracing what this is necessary for. It's related to > the notify_decorator which is around for legacy notifications but I don't > actually see that decorator used anywhere. Given there are other

[openstack-dev] [nova] Can we remove the monkey_patch_modules config option?

2017-08-25 Thread Matt Riedemann
I'm having a hard time tracing what this is necessary for. It's related to the notify_decorator which is around for legacy notifications but I don't actually see that decorator used anywhere. Given there are other options related to the notify_decorator, like "default_publisher_id" if we can