Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-06 Thread Zhenyu Zheng
Thanks a lot for the reply. I have already registered a BP for this, and will submit a spec for N, we can discuss the details in the spec then. On Sun, Mar 6, 2016 at 2:01 AM, Matt Riedemann wrote: > > > On 3/5/2016 9:48 AM, Adam Young wrote: > >> On 03/05/2016

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-05 Thread Matt Riedemann
On 3/5/2016 9:48 AM, Adam Young wrote: On 03/05/2016 12:27 AM, Chris Friesen wrote: On 03/04/2016 03:42 PM, Matt Riedemann wrote: On 3/3/2016 9:14 PM, Zhenyu Zheng wrote: Hm, I found out the reason:

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-05 Thread Adam Young
On 03/05/2016 12:27 AM, Chris Friesen wrote: On 03/04/2016 03:42 PM, Matt Riedemann wrote: On 3/3/2016 9:14 PM, Zhenyu Zheng wrote: Hm, I found out the reason: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1139-L1145 here we filtered out parameters

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-04 Thread Chris Friesen
On 03/04/2016 03:42 PM, Matt Riedemann wrote: On 3/3/2016 9:14 PM, Zhenyu Zheng wrote: Hm, I found out the reason: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1139-L1145 here we filtered out parameters like "deleted", and that's why the API behavior

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-04 Thread Matt Riedemann
On 3/3/2016 9:14 PM, Zhenyu Zheng wrote: Hm, I found out the reason: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1139-L1145 here we filtered out parameters like "deleted", and that's why the API behavior is like above mentioned. So should we simple add

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Zhenyu Zheng
Hm, I found out the reason: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L1139-L1145 here we filtered out parameters like "deleted", and that's why the API behavior is like above mentioned. So should we simple add "deleted" to the tuple or a microversion is

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Zhenyu Zheng
Anyway, I updated the bug report: https://bugs.launchpad.net/nova/+bug/1552071 and I will start to working on the bug first. On Fri, Mar 4, 2016 at 9:29 AM, Zhenyu Zheng wrote: > Yes, so you are suggest fixing the return data of non-admin user use 'nova > list

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Zhenyu Zheng
Yes, so you are suggest fixing the return data of non-admin user use 'nova list --deleted' but leave non-admin using 'nova list --status=deleted' as is. Or it would be better to also submit a BP for next cycle to add support for non-admin using '--status=deleted' with microversions. Because in my

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Matt Riedemann
On 3/3/2016 2:55 AM, Zhenyu Zheng wrote: Yes, I agree with you guys, I'm also OK for non-admin users to list their own instances no matter what status they are. My question is this: I have done some tests, yet we have 2 different ways to list deleted instances (not counting using

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Matt Riedemann
On 3/3/2016 10:02 AM, Matt Riedemann wrote: On 3/3/2016 2:55 AM, Zhenyu Zheng wrote: Yes, I agree with you guys, I'm also OK for non-admin users to list their own instances no matter what status they are. My question is this: I have done some tests, yet we have 2 different ways to list

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Zhenyu Zheng
Yes, I agree with you guys, I'm also OK for non-admin users to list their own instances no matter what status they are. My question is this: I have done some tests, yet we have 2 different ways to list deleted instances (not counting using changes-since): 1. "GET

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-03 Thread Alex Xu
2016-03-03 2:11 GMT+08:00 Matt Riedemann : > > > On 3/2/2016 3:02 AM, Zhenyu Zheng wrote: > >> Hi, Nova, >> >> While I'm working on add "changes-since" parameter support for >> python-novaclient "list" CLI. >> >> I realized that non-admin can list all deleted instances

Re: [openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-02 Thread Matt Riedemann
On 3/2/2016 3:02 AM, Zhenyu Zheng wrote: Hi, Nova, While I'm working on add "changes-since" parameter support for python-novaclient "list" CLI. I realized that non-admin can list all deleted instances using "changes-since" parameter. This is reasonable in some level, as delete is an update

[openstack-dev] [nova] Non-Admin user can show deleted instances using changes-since parameter when calling list API

2016-03-02 Thread Zhenyu Zheng
Hi, Nova, While I'm working on add "changes-since" parameter support for python-novaclient "list" CLI. I realized that non-admin can list all deleted instances using "changes-since" parameter. This is reasonable in some level, as delete is an update to instances. But as we have a limitation that