Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-20 Thread Mehdi Abaakouk
Hi, Also to support some of the newer services that don't use paste i think we should absolutely make it so that the CONF object is passed to middleware rather than sourced globally. I think gnochhi and zaqar both fit into this case. For example, Gnocchi doesn't use paste, deployer adds middle

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-20 Thread Mehdi Abaakouk
It looks like the additional features added, in particular the 'oslo_config_project' property, needs to be documented. I have added some documentation into the keystonemiddleware too: https://review.openstack.org/#/c/208965/ --- Mehdi Abaakouk mail: sil...@sileht.net irc: sileht __

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-11 Thread Julien Danjou
On Tue, Aug 11 2015, Michael Krotscheck wrote: > It looks like the additional features added, in particular the > 'oslo_config_project' property, needs to be documented. It has been documented with one of the patch, you can see it here: http://docs.openstack.org/developer/oslo.middleware/oslo

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-11 Thread Michael Krotscheck
It looks like the additional features added, in particular the 'oslo_config_project' property, needs to be documented. A deeper read shows that you're right, existing functionality was not broken. Apologies for being heavy handed in my response. Michael On Tue, Aug 11, 2015 at 2:53 AM Julien Da

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-11 Thread Julien Danjou
On Mon, Aug 10 2015, Michael Krotscheck wrote: Hi Michael, > It appears that the patch related to this discussion were rushed through > rather quickly, and without appropriate updates to the documentation. The > documentation of the library no longer matches the actual functionality, > and will n

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-10 Thread Michael Krotscheck
Jamie Lennox wrote: > > > - Original Message - > > From: "Jamie Lennox" > > To: "OpenStack Development Mailing List (not for usage questions)" < > openstack-dev@lists.openstack.org> > > Sent: Monday, August 10, 2015 12:36:14 PM > >

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-09 Thread Jamie Lennox
- Original Message - > From: "Jamie Lennox" > To: "OpenStack Development Mailing List (not for usage questions)" > > Sent: Monday, August 10, 2015 12:36:14 PM > Subject: Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middleware

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-09 Thread Jamie Lennox
- Original Message - > From: "Mehdi Abaakouk" > To: openstack-dev@lists.openstack.org > Sent: Friday, August 7, 2015 1:57:54 AM > Subject: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares > > Hi, > > I want to share with you some pr

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-08 Thread Julien Danjou
On Fri, Aug 07 2015, Michael Krotscheck wrote: > Here's the thing. If the middleware is _optional_ like keystone auth, then > including it via paste.ini makes way more sense. In fact, keystone auth has > gone to great lengths to have no dependencies for that very same reason. > If, instead, the mi

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-07 Thread Joshua Harlow
Michael Krotscheck wrote: On Thu, Aug 6, 2015 at 10:08 AM Mehdi Abaakouk mailto:sil...@sileht.net>> wrote: Yes, but you can't use oslo.config without hardcode the loading the middleware to pass the oslo.config object into the application. Yes, and that is intentional, because the use

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-07 Thread Michael Krotscheck
On Thu, Aug 6, 2015 at 10:08 AM Mehdi Abaakouk wrote: > > Yes, but you can't use oslo.config without hardcode the loading the > middleware to pass the oslo.config object into the application. > Yes, and that is intentional, because the use of global variables of any sort is bad. They're unconstr

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-06 Thread Mehdi Abaakouk
On Thu, Aug 06, 2015 at 04:25:58PM +, Michael Krotscheck wrote: > Hi there! > > The most recent version of the CORS middleware (~2.4) no longer requires > the use of Oslo.config, and supports pastedeploy. While using oslo.config > provides far better features - such as multiple origins - it do

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-06 Thread Julien Danjou
On Thu, Aug 06 2015, Mehdi Abaakouk wrote: > This is confusing for developer to have some middlewares that need pre-setup, > enforce them to rely on global python object, and some others not. > This is confusing for deployer their can't do the configuration of middlewares > in the same way for eac

Re: [openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-06 Thread Michael Krotscheck
Hi there! The most recent version of the CORS middleware (~2.4) no longer requires the use of Oslo.config, and supports pastedeploy. While using oslo.config provides far better features - such as multiple origins - it doesn't prevent you from using it in the paste pipeline. The documentation has b

[openstack-dev] [oslo][keystone] oslo_config and wsgi middlewares

2015-08-06 Thread Mehdi Abaakouk
Hi, I want to share with you some problems I have recently encountered with openstack middlewares and oslo.config. The issues -- In project Gnocchi, I would use oslo.middleware.cors, I have expected to just put the name of the middleware to the wsgi pipeline, but I can't. The middlew