Re: [openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

Good find ;) Davanum Srinivas wrote: Josh, Haha, see note from russellb :) http://git.openstack.org/cgit/openstack/nova/tree/nova/network/rpcapi.py#n308 On Thu, Mar 17, 2016 at 6:44 PM, Joshua Harlow wrote: In a follow-up to this. Seems like the patch to

Re: [openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

Josh, Haha, see note from russellb :) http://git.openstack.org/cgit/openstack/nova/tree/nova/network/rpcapi.py#n308 On Thu, Mar 17, 2016 at 6:44 PM, Joshua Harlow wrote: > In a follow-up to this. > > Seems like the patch to disable/disallow this itself found some

Re: [openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

On 03/18/2016 12:22 PM, Doug Hellmann wrote: We need the warning to show up in the calling side, so if we can look at the name there and emit the warning that would be a good start. Then changing oslo.messaging to not allow calling private methods would be an API break, and require raising the

Re: [openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

In a follow-up to this. Seems like the patch to disable/disallow this itself found some 'violations' @ http://logs.openstack.org/24/289624/3/check/gate-oslo.messaging-src-dsvm-full-amqp1-centos7/e3b485c/console.html.gz#_2016-03-11_00_06_56_177 Details: {u'message': u'Unable to associate

Re: [openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

Excerpts from Joshua Harlow's message of 2016-03-17 15:44:06 -0700: > In a follow-up to this. > > Seems like the patch to disable/disallow this itself found some > 'violations' @ >

Re: [openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

So during this exploration of this code for the above review it made me wonder if this is a feature or bug, or if we should at least close the hole of allowing calling into nearly any endpoint method/attribute (even non-callable ones to?). ... Thoughts? I agree that doesn't make any sense to

[openstack-dev] [oslo] oslo.messaging dispatching into private/protected methods?

Hi all, As I was working through https://review.openstack.org/#/c/288719/ for kevin benton to do some things with in neutron it came to my understanding that this code (the dispatcher code that is) can dispatch into nearly arbitrary callables of any object (or that is what it looks like it