Re: [openstack-dev] Doc to with pointers on how to review?

2014-04-01 Thread Jeremy Stanley
On 2014-03-31 13:28:24 +0900 (+0900), Emmet Hikory wrote: > There are any number of projects that may have specific requirements > that aren't documented on that page (please add them), but I found that > having read that gave me great confidence to submit more reviews. I also just updated it to r

Re: [openstack-dev] Doc to with pointers on how to review?

2014-03-30 Thread Tom Fifield
On 31/03/14 12:24, Ruslan Kamaldinov wrote: On Mon, Mar 31, 2014 at 5:57 AM, Tom Fifield wrote: Hi, Just wondering, do we have a document somewhere that educates people on how to do a code review? eg giving a few pointers that reviewers for a particular project normally look for Hi Tom, The

Re: [openstack-dev] Doc to with pointers on how to review?

2014-03-30 Thread Emmet Hikory
Tom Fifield wrote: > Just wondering, do we have a document somewhere that educates people > on how to do a code review? eg giving a few pointers that reviewers > for a particular project normally look for I asked this very question on IRC a few days ago, and was pointed at https://wiki.opensta

Re: [openstack-dev] Doc to with pointers on how to review?

2014-03-30 Thread Ruslan Kamaldinov
On Mon, Mar 31, 2014 at 5:57 AM, Tom Fifield wrote: > Hi, > > Just wondering, do we have a document somewhere that educates people on how > to do a code review? eg giving a few pointers that reviewers for a > particular project normally look for Hi Tom, The closest to your description document i

[openstack-dev] Doc to with pointers on how to review?

2014-03-30 Thread Tom Fifield
Hi, Just wondering, do we have a document somewhere that educates people on how to do a code review? eg giving a few pointers that reviewers for a particular project normally look for So far everything I've seen (aside from https://wiki.openstack.org/wiki/GerritJenkinsGit#Reviewing_a_Change)