[openstack-dev] Duplicate code for processing REST APIs

2014-03-13 Thread Steven Kaufer
While investigating some REST API updates I've discovered that there is a lot of duplicated code across the various OpenStack components. For example, the paginate_query function exists in all these locations and there are a few slight differences between most of them: https://github.com/openst

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-13 Thread Roman Podoliaka
Hi Steven, Code from openstack/common/ dir is 'synced' from oslo-incubator. The 'sync' is effectively a copy of oslo-incubator subtree into a project source tree. As syncs are not done at the same time, the code of synced modules may indeed by different for each project depending on which commit o

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-13 Thread Kevin L. Mitchell
On Thu, 2014-03-13 at 16:03 -0500, Steven Kaufer wrote: > While investigating some REST API updates I've discovered that there > is a lot of duplicated code across the various OpenStack components. > > For example, the paginate_query function exists in all these locations > and there are a few sli

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-13 Thread Matt Riedemann
On 3/13/2014 4:13 PM, Roman Podoliaka wrote: Hi Steven, Code from openstack/common/ dir is 'synced' from oslo-incubator. The 'sync' is effectively a copy of oslo-incubator subtree into a project source tree. As syncs are not done at the same time, the code of synced modules may indeed by diffe

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-14 Thread Duncan Thomas
On 13 March 2014 21:13, Roman Podoliaka wrote: > Hi Steven, > > Code from openstack/common/ dir is 'synced' from oslo-incubator. The > 'sync' is effectively a copy of oslo-incubator subtree into a project > source tree. As syncs are not done at the same time, the code of > synced modules may indee

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-14 Thread Roman Podoliaka
Hi all, >>> Worth noting that there have been a few cases of projects patching OSLO >>> bugs intheir own tree rather than fixing in OSLO then resyncing. If anybody >>> has any tooling that can detect that, I'd love to see the results. They shouldn't have done that :( I totally agree, that 'syn

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-14 Thread Jay S Bryant
From: Duncan Thomas To: "OpenStack Development Mailing List (not for usage questions)" , Date: 03/14/2014 11:56 AM Subject: Re: [openstack-dev] Duplicate code for processing REST APIs On 13 March 2014 21:13, Roman Podoliaka wrote: > Hi Steven, > > Code fr

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-14 Thread Solly Ross
t for usage questions)" Sent: Friday, March 14, 2014 3:12:22 PM Subject: Re: [openstack-dev] Duplicate code for processing REST APIs From: Duncan Thomas To: "OpenStack Development Mailing List (not for usage questions)" , Date: 03/14/2014 11:56 AM Subject: Re: [openstack-dev] Du

Re: [openstack-dev] Duplicate code for processing REST APIs

2014-03-14 Thread Doug Hellmann
On Fri, Mar 14, 2014 at 12:48 PM, Duncan Thomas wrote: > On 13 March 2014 21:13, Roman Podoliaka wrote: > > Hi Steven, > > > > Code from openstack/common/ dir is 'synced' from oslo-incubator. The > > 'sync' is effectively a copy of oslo-incubator subtree into a project > > source tree. As syncs a