[openstack-dev] False Positive testing for 3rd party CI

2014-02-21 Thread Aaron Rosen
Hi, Yesterday, I pushed a patch to review and was surprised that several of the third party CI systems reported back that the patch-set worked where it definitely shouldn't have. Anyways, I tested out my theory a little more and it turns out a few of the 3rd party CI systems for neutron are just r

Re: [openstack-dev] False Positive testing for 3rd party CI

2014-02-21 Thread Octavian Ciuhandu
Hi, On 21 Feb 2014, at 20:34, Aaron Rosen mailto:aaronoro...@gmail.com>> wrote: Hi, Yesterday, I pushed a patch to review and was surprised that several of the third party CI systems reported back that the patch-set worked where it definitely shouldn't have. Anyways, I tested out my theory a

Re: [openstack-dev] False Positive testing for 3rd party CI

2014-02-21 Thread Aaron Rosen
This should fix the false positive for brocade: https://review.openstack.org/#/c/75486/ Aaron On Fri, Feb 21, 2014 at 10:34 AM, Aaron Rosen wrote: > Hi, > > Yesterday, I pushed a patch to review and was surprised that several of > the third party CI systems reported back that the patch-set wor

Re: [openstack-dev] False Positive testing for 3rd party CI

2014-02-21 Thread Armando M.
Nice one! On 21 February 2014 11:22, Aaron Rosen wrote: > This should fix the false positive for brocade: > https://review.openstack.org/#/c/75486/ > > Aaron > > > On Fri, Feb 21, 2014 at 10:34 AM, Aaron Rosen wrote: >> >> Hi, >> >> Yesterday, I pushed a patch to review and was surprised that se

Re: [openstack-dev] False Positive testing for 3rd party CI

2014-02-21 Thread Carl Baldwin
Aaron, I was thinking the same thing recently with this patch [1]. Patch sets 1-5 should have failed for any plugin besides ml2 yet some passed and I wondered how that could happen. Kudos to those patches that failed my patch sets correctly. Carl [1] https://review.openstack.org/#/c/72565/ On

Re: [openstack-dev] False Positive testing for 3rd party CI

2014-02-23 Thread Hemanth Ravi
One Convergence CI did report the third party tests as failed, but is configured not to vote. Should we turn on the voting? Thanks, -hemanth On Fri, Feb 21, 2014 at 1:29 PM, Carl Baldwin wrote: > Aaron, > > I was thinking the same thing recently with this patch [1]. Patch > sets 1-5 should ha

Re: [openstack-dev] False Positive testing for 3rd party CI

2014-02-23 Thread Akihiro Motoki
Thanks Aaron, it is really interesting. > The Hyper-V CI is non-voting (as required for new third-party CIs) and this > is the reason why any post from it will show “build succeeded”. As published > in other threads, AFAIK the only way to get rid > of this issue is to have the CI as voting.