Hello! I'm writing to suggest that git-review requires to be covered by tests. There are no testing part in it at all, so maybe it is a good idea to cover it.
There are two types of tests to be implemented to cover the project: * unit tests to verify working of the separated methods * integrated tests that are using local copy of Gerrit Unit tests have to mock needed calls to find out working of Python functions used in git-review. The integrated tests are supposed to have the following workflow: * clear (or create) folder with the Gerrit environment for the every test * create new projects and push (--force) everything needed into test branches * clone project repository and create some new commits there * use git-review to check out how does it work -- Best regards, Dina
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
