Re: [openstack-dev] Re : welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-11-04 Thread John Dennis
On 10/31/2013 10:36 PM, Jeremy Stanley wrote: As has been said many times already, OpenStack does not lack developers... it lacks reviewers. In regards to reviews in general and in particular for welcoming new committers I think we need to be careful about reviewers NAK'ing a submission for

Re: [openstack-dev] Re : welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-11-04 Thread Ravi Chunduru
Good points from John. The only concern for first time reviewers is that their comments gets overseen by the committer. If the review comment is good, I feel core-reviewer must put some weight on it and thus encourage genuine suggestions. On Mon, Nov 4, 2013 at 9:33 AM, John Dennis

Re: [openstack-dev] Re : welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-11-01 Thread David Kranz
On 10/31/2013 10:36 PM, Jeremy Stanley wrote: On 2013-10-31 22:45:56 + (+), Romain Hardouin wrote: Adding a message for new comers is a good idea. I am a new Horizon contributor, some of my fixes have been merged (thanks to Upstream University :-) and reviewers of course) but I still

[openstack-dev] Re : welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Romain Hardouin
Hi all, br/br/Adding a message for new comers is a good idea. br/I am a new Horizon contributor, some of my fixes have been merged (thanks to Upstream University :-) and reviewers of course) but I still hesitate to do code review. To my mind, it is reserved to known developpers whose opinion

Re: [openstack-dev] Re : welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?)

2013-10-31 Thread Jeremy Stanley
On 2013-10-31 22:45:56 + (+), Romain Hardouin wrote: Adding a message for new comers is a good idea. I am a new Horizon contributor, some of my fixes have been merged (thanks to Upstream University :-) and reviewers of course) but I still hesitate to do code review. To my mind, it is