Re: [openstack-dev] Remove vim modelines?

2013-10-29 Thread David Stanek
On Thu, Oct 24, 2013 at 2:48 PM, Robert Collins wrote: > > > *) They help casual contributors *more* than long time core > contributors : and those are the folk that are most likely to give up > and walk away. Keeping barriers to entry low is an important part of > making OpenStack development acce

Re: [openstack-dev] Remove vim modelines?

2013-10-29 Thread Andrew Laski
On 10/29/13 at 10:53am, Joe Gordon wrote: So after over 20 messages in this thread, now what? From my count we have 3 -, and 12 +1s. Is that enough for consensus? Do we move modelines lines to the bottom? Put them in every file? Or just remove them? I have no strong feeling either way on kee

Re: [openstack-dev] Remove vim modelines?

2013-10-29 Thread Joe Gordon
On Tue, Oct 29, 2013 at 11:17 AM, Robert Collins wrote: > On 28 October 2013 23:54, Joe Gordon wrote: > > > > We don't just gate without telling people, the first two items in hacking > > are read pep8 > > > > http://docs.openstack.org/developer/hacking/ > > The gate is super useful, but it's rea

Re: [openstack-dev] Remove vim modelines?

2013-10-29 Thread Robert Collins
On 28 October 2013 23:54, Joe Gordon wrote: > We don't just gate without telling people, the first two items in hacking > are read pep8 > > http://docs.openstack.org/developer/hacking/ The gate is super useful, but it's reactive, not proactive. And good documentation isn't a replacement for jus

Re: [openstack-dev] Remove vim modelines?

2013-10-29 Thread Joe Gordon
So after over 20 messages in this thread, now what? >From my count we have 3 -, and 12 +1s. Is that enough for consensus? Do we move modelines lines to the bottom? Put them in every file? Or just remove them? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topi

Re: [openstack-dev] Remove vim modelines?

2013-10-28 Thread Joe Gordon
On Mon, Oct 28, 2013 at 9:35 AM, Alexis Lee wrote: > As a new OpenStack contributor, +1 for lower barriers to entry. It's > helpful for OS to inform editor style and I don't believe in the > arguments to remove them. > > > Why remove them? > > * we could shrink our codebase by a little bit. > > W

Re: [openstack-dev] Remove vim modelines?

2013-10-28 Thread Alexis Lee
As a new OpenStack contributor, +1 for lower barriers to entry. It's helpful for OS to inform editor style and I don't believe in the arguments to remove them. > Why remove them? > * we could shrink our codebase by a little bit. Why do you want to shrink it? Simplify, sure, but modelines are not

Re: [openstack-dev] Remove vim modelines?

2013-10-26 Thread Ruslan Kiianchuk
If someone takes effort to learn Vim to the point when he/she develops code in it, they most definitely have their preferred settings already, why overwrite them? If those settings conflict with the style guide -- it has been said, pep8 and hacking check will notify. I always thought that leaving

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Vishvananda Ishaya
Interesting Background Information: Why do we have modelines? Termie put them in all the files of the first version of nova Why did he put in modelines instead of configuring his editor? Termie does a lot of python coding and he prefers a tabstop of 2 on all his personal projects[1] I really

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Ed Leafe
On Oct 25, 2013, at 3:12 PM, John Dennis wrote: > And what about other editors? Where do you stop? > > My personal feeling is you need to have enough awareness to configure > your editor correctly to contribute to a project. It's your > responsibility and our gate tools will hold you to that pro

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread John Dennis
On 10/25/2013 03:43 PM, Robert Collins wrote: > On 26 October 2013 08:40, Dolph Mathews wrote: >> >> On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins >> wrote: >>> >>> >>> *) They help casual contributors *more* than long time core >>> contributors : and those are the folk that are most likely to

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Dean Troyer
On Fri, Oct 25, 2013 at 2:43 PM, Robert Collins wrote: > On 26 October 2013 08:40, Dolph Mathews wrote:> > I'm all for low barriers of entry, so if there's > > any evidence that this is true, I'd want to make them more prolific. > > I'm not sure how to gather evidence for this, either for or agai

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Dolph Mathews
On Fri, Oct 25, 2013 at 2:43 PM, Robert Collins wrote: > On 26 October 2013 08:40, Dolph Mathews wrote: > > > > On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins < > robe...@robertcollins.net> > > wrote: > >> > >> > >> *) They help casual contributors *more* than long time core > >> contributors :

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Robert Collins
On 26 October 2013 08:40, Dolph Mathews wrote: > > On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins > wrote: >> >> >> *) They help casual contributors *more* than long time core >> contributors : and those are the folk that are most likely to give up >> and walk away. Keeping barriers to entry low

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Dolph Mathews
On Thu, Oct 24, 2013 at 1:48 PM, Robert Collins wrote: > > *) They help casual contributors *more* than long time core > contributors : and those are the folk that are most likely to give up > and walk away. Keeping barriers to entry low is an important part of > making OpenStack development acces

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Paul Nelson
o the other way > and just add them everywhere. > > May I ask why? Do you use the modeline? > > > > > - Original Message - > > > From: "Joe Gordon" > > > To: "OpenStack Development Mailing List" < > openstack-dev@lists.ope

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Joe Gordon
uot; > > To: "OpenStack Development Mailing List" < openstack-dev@lists.openstack.org> > > Sent: Thursday, October 24, 2013 8:38:57 AM > > Subject: [openstack-dev] Remove vim modelines? > > > > Since the beginning of OpenStack we have had vim modeline

Re: [openstack-dev] Remove vim modelines?

2013-10-25 Thread Dan Prince
-1 Slight preference for keeping them. I personally would go the other way and just add them everywhere. - Original Message - > From: "Joe Gordon" > To: "OpenStack Development Mailing List" > Sent: Thursday, October 24, 2013 8:38:57 AM > Subject: [open

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Robert Collins
I guess I get to buck the trend :). On 25 October 2013 01:38, Joe Gordon wrote: > Since the beginning of OpenStack we have had vim modelines all over the > codebase, but after seeing this patch > https://review.opeenstack.org/#/c/50891/ I took a further look into vim > modelines and think we shou

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Morgan Fainberg
+1 and likely this should be added to hacking so they don't sneak back in by accident / reviewers missing the line since we've had them for do long. On Thursday, October 24, 2013, Flavio Percoco wrote: > On 24/10/13 13:38 +0100, Joe Gordon wrote: > >> Since the beginning of OpenStack we have had

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Dolph Mathews
On Thu, Oct 24, 2013 at 8:19 AM, Flavio Percoco wrote: > On 24/10/13 13:38 +0100, Joe Gordon wrote: > >> Since the beginning of OpenStack we have had vim modelines all over the >> codebase, but after seeing this patch https://review.opeenstack.org/** >> #/c/50891/

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread David Ripton
On 10/24/2013 08:38 AM, Joe Gordon wrote: Why remove them? * Modelines aren't supported by default in debian or ubuntu due to security reasons: https://wiki.python.org/moin/Vim * Having modelines for vim means if someone wants we should support modelines for emacs (http://www.gnu.org/software/e

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Yuriy Taraday
+1 on the topic How about we catch them in hacking so that they won't ever come back? On Thu, Oct 24, 2013 at 4:53 PM, Davanum Srinivas wrote: > +1 to remove them. > > -- dims > > On Thu, Oct 24, 2013 at 8:44 AM, Monty Taylor > wrote: > > > > > > On 10/24/2013 08:38 AM, Joe Gordon wrote: > >>

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Flavio Percoco
On 24/10/13 13:38 +0100, Joe Gordon wrote: Since the beginning of OpenStack we have had vim modelines all over the codebase, but after seeing this patch https://review.opeenstack.org/#/c/50891/ I took a further look into vim modelines and think we should remove them. Before going any further, I s

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Davanum Srinivas
+1 to remove them. -- dims On Thu, Oct 24, 2013 at 8:44 AM, Monty Taylor wrote: > > > On 10/24/2013 08:38 AM, Joe Gordon wrote: >> Since the beginning of OpenStack we have had vim modelines all over the >> codebase, but after seeing this >> patch https://review.opeenstack.org/#/c/50891/ >>

Re: [openstack-dev] Remove vim modelines?

2013-10-24 Thread Monty Taylor
On 10/24/2013 08:38 AM, Joe Gordon wrote: > Since the beginning of OpenStack we have had vim modelines all over the > codebase, but after seeing this > patch https://review.opeenstack.org/#/c/50891/ > I took a further look into vim > modelines and think w

[openstack-dev] Remove vim modelines?

2013-10-24 Thread Joe Gordon
Since the beginning of OpenStack we have had vim modelines all over the codebase, but after seeing this patch https://review.opeenstack.org/#/c/50891/I took a further look into vim modelines and think we should remove them. Before going any further, I should