Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-30 Thread Mike Bayer
On 01/24/2017 04:49 AM, Kirill Proskurin wrote: HI! Thing is, running Galera without enforcing it very bad idea for production use. Permissive mode was added more or less for testing purposes, running real production with it is dangerous, since it's not enforcing the mandatory Galera

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-25 Thread Anna Taraday
Change against master merged. Backport for Newton - https://review.openstack.org/#/c/419320/ On Tue, Jan 24, 2017 at 7:44 PM Davanum Srinivas wrote: > Cool. Then i'd support a backport when the review against master > merges. Thanks Ann and Kirill. > > -- Dims > > On Tue, Jan

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Davanum Srinivas
Cool. Then i'd support a backport when the review against master merges. Thanks Ann and Kirill. -- Dims On Tue, Jan 24, 2017 at 10:33 AM, Anna Taraday wrote: > Nope, this won't be necessary. > > 0.8.10 - allows us to create pk on alembic_version table automatically,

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Anna Taraday
Nope, this won't be necessary. 0.8.10 - allows us to create pk on alembic_version table automatically, but only for new deployments. I propose manually add pk on this table if it is not existing. On Tue, Jan 24, 2017 at 7:25 PM Davanum Srinivas wrote: > Ann, > > Don't you

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Davanum Srinivas
Ann, Don't you still need alembic>=0.8.10 to be present? -- Dims On Tue, Jan 24, 2017 at 10:05 AM, Anna Taraday wrote: > We do not backport db changes, but if the existing migration does not work > in certain circumstances, should not we fix it to make it work if it

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Anna Taraday
We do not backport db changes, but if the existing migration does not work in certain circumstances, should not we fix it to make it work if it is possible? This will allow to deploy new deployments with Newton code on Galera. On Tue, Jan 24, 2017 at 6:45 PM Davanum Srinivas

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Davanum Srinivas
Please see http://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines On Tue, Jan 24, 2017 at 9:34 AM, Davanum Srinivas wrote: > Newton is already shipped! > > -- Dims > > On Tue, Jan 24, 2017 at 9:23 AM, Kirill Proskurin >

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Davanum Srinivas
Newton is already shipped! -- Dims On Tue, Jan 24, 2017 at 9:23 AM, Kirill Proskurin wrote: > Galera only supported since Ocata? > > On Tue, Jan 24, 2017 at 4:30 PM, Davanum Srinivas wrote: >> >> Kirill, >> >> "If OS wants support Galera, it needs to

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Kirill Proskurin
Galera only supported since Ocata? On Tue, Jan 24, 2017 at 4:30 PM, Davanum Srinivas wrote: > Kirill, > > "If OS wants support Galera, it needs to comply with the Galera > requirements" <<< This is true for master/ocata NOT Newton. > > Ihar's response is perfectly acceptable

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Davanum Srinivas
Kirill, "If OS wants support Galera, it needs to comply with the Galera requirements" <<< This is true for master/ocata NOT Newton. Ihar's response is perfectly acceptable thing to do for Newton in the community to highlight the possibility of this situation. Downstream folks can do what they

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-24 Thread Kirill Proskurin
HI! Thing is, running Galera without enforcing it very bad idea for production use. Permissive mode was added more or less for testing purposes, running real production with it is dangerous, since it's not enforcing the mandatory Galera requirement, one of them is a "All tables must have a

Re: [openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-23 Thread Ihar Hrachyshka
An alternative could also be, for Newton and earlier, to release a note saying that operators should not run the code against ENFORCING galera mode. What are the reasons to enable that mode in OpenStack scope that would not allow operators to live without it for another cycle? Ihar On Mon, Jan

[openstack-dev] [All projects that use Alembic] Absence of pk on alembic_version table

2017-01-23 Thread Anna Taraday
Hello everyone! Guys in our team faced an issue when they try to run alembic migrations on Galera with ENFORCING mode. [1] This was an issue with Alembic [2], which was quickly fixed by Mike Bayer (many thanks!) and new version of alembic was resealed [3]. The global requirements are updated