Re: [openstack-dev] [nova][oslo] what to do with problematic mocking in nova unit tests

2018-04-03 Thread Doug Hellmann
Excerpts from Eric Fried's message of 2018-03-31 16:12:22 -0500: > Hi Doug, I made this [2] for you. I tested it locally with oslo.config > master, and whereas I started off with a slightly different set of > errors than you show at [1], they were in the same suites. Since I > didn't want to tox

Re: [openstack-dev] [nova][oslo] what to do with problematic mocking in nova unit tests

2018-03-31 Thread Eric Fried
Hi Doug, I made this [2] for you. I tested it locally with oslo.config master, and whereas I started off with a slightly different set of errors than you show at [1], they were in the same suites. Since I didn't want to tox the world locally, I went ahead and added a Depends-On from [3]. Let's

Re: [openstack-dev] [nova][oslo] what to do with problematic mocking in nova unit tests

2018-03-30 Thread Doug Hellmann
Anyone? > On Mar 28, 2018, at 1:26 PM, Doug Hellmann wrote: > > In the course of preparing the next release of oslo.config, Ben noticed > that nova's unit tests fail with oslo.config master [1]. > > The underlying issue is that the tests mock things that oslo.config > is

[openstack-dev] [nova][oslo] what to do with problematic mocking in nova unit tests

2018-03-28 Thread Doug Hellmann
In the course of preparing the next release of oslo.config, Ben noticed that nova's unit tests fail with oslo.config master [1]. The underlying issue is that the tests mock things that oslo.config is now calling as part of determining where options are being set in code. This isn't an API change