Re: [openstack-dev] requests-mock

2016-10-11 Thread Clay Gerrard
On Tue, Oct 11, 2016 at 4:24 PM, Jamie Lennox wrote: > > So I'm not going to comment too much on the quality of the library as i > obviously think it's good > acahcpahch, no worries. Your insights are invaluable - thanks for taking the time to connect some dots for me -

Re: [openstack-dev] requests-mock

2016-10-11 Thread Jamie Lennox
On 11 October 2016 at 16:23, Clay Gerrard wrote: > Greetings! > > Anyone have any experience to share positive or negative using > requests-mock? I see it's been used to replace another dependency that had > some problems in many of the OpenStack python client libraries:

Re: [openstack-dev] requests-mock

2016-10-11 Thread Clay Gerrard
On Tue, Oct 11, 2016 at 10:44 AM, Clay Gerrard wrote: > I'm not really sure what a fixture is this context? > Answered my own question in this case! http://requests-mock.readthedocs.io/en/latest/fixture.html It's one of *these* of course:

Re: [openstack-dev] requests-mock

2016-10-11 Thread Clay Gerrard
On Tue, Oct 11, 2016 at 5:40 AM, Ian Cordasco wrote: > So, as a core developer > of Requests, I would endorse requests-mock for this category of > dependency. > Excellent; exactly the kind of feedback I was hoping to solicit. If you're looking to add this catagory of

Re: [openstack-dev] requests-mock

2016-10-11 Thread Ian Cordasco
ck.org> Subject:  [openstack-dev] requests-mock > Greetings! > > Anyone have any experience to share positive or negative using > requests-mock? I see it's been used to replace another dependency that had > some problems in many of the OpenStack python client libraries: > >

Re: [openstack-dev] requests-mock

2016-10-11 Thread Davanum Srinivas
Clay, Apologies for the top post. Here's the current recommendation on dependencies - Answering your question on "I'm not acctually sure what the OpenStack policy is on dependency hygiene :D Anyway,": https://github.com/openstack/requirements#global-requirements-for-openstack-projects There is

[openstack-dev] requests-mock

2016-10-10 Thread Clay Gerrard
Greetings! Anyone have any experience to share positive or negative using requests-mock? I see it's been used to replace another dependency that had some problems in many of the OpenStack python client libraries: Added to global requirements -> https://review.openstack.org/#/c/104067 Added to